Skynet/wiki
22
1
Fork 8
Code Issues 1 Pull requests Projects Wiki Activity Actions

docs: review process documentation in PR guide #43

Merged
silver merged 3 commits from nanda/wiki:main into main 2026-03-28 23:50:56 +00:00
Conversation 6 Commits 3 Files changed 5 +33 -1
nanda commented 2026-03-28 23:32:17 +00:00
Owner
Copy link

Added documentation for reviewing PRs

Added documentation for reviewing PRs
docs: review process documentation in PR guide
All checks were successful
/ check_lfs (pull_request) Successful in 2s
Details
96da5fe871
nanda self-assigned this 2026-03-28 23:32:19 +00:00
nanda requested review from silver 2026-03-28 23:35:23 +00:00
silver requested changes 2026-03-28 23:38:42 +00:00
Dismissed
silver left a comment
Owner
Copy link

Would ye be able to add a note that to view LFS files in a PR ye have to go to the source repo?

For example 96da5fe871/src/committee/onboarding/pr/dismiss_review.png shows up as just its pointer
But on yer onw its perfectly fine forgejo.skynet.ie/nanda/wiki/media@96da5fe871/src/committee/onboarding/pr/dismiss_review.png

Would ye be able to add a note that to view LFS files in a PR ye have to go to the source repo? For example https://forgejo.skynet.ie/Skynet/wiki/src/commit/96da5fe871d4d8c791c25438eca8593b2f2a9ce7/src/committee/onboarding/pr/dismiss_review.png shows up as just its pointer But on yer onw its perfectly fine https://forgejo.skynet.ie/nanda/wiki/media/commit/96da5fe871d4d8c791c25438eca8593b2f2a9ce7/src/committee/onboarding/pr/dismiss_review.png
docs: add note on viewing LFS files in PRs
All checks were successful
/ check_lfs (pull_request) Successful in 2s
Details
f40f53f7bc
nanda commented 2026-03-28 23:43:36 +00:00
Author
Owner
Copy link

@silver wrote in #43 (comment):

Would ye be able to add a note that to view LFS files in a PR ye have to go to the source repo?

For example 96da5fe871/src/committee/onboarding/pr/dismiss_review.png shows up as just its pointer But on yer onw its perfectly fine forgejo.skynet.ie/nanda/wiki/media@96da5fe871/src/committee/onboarding/pr/dismiss_review.png

Fixed by adding the following string:

NOTE: To view LFS files (like images) in a PR, you need to open them from the source repository OR via the "Files Changed" tab on the PR.

@silver wrote in https://forgejo.skynet.ie/Skynet/wiki/pulls/43#issuecomment-3108: > Would ye be able to add a note that to view LFS files in a PR ye have to go to the source repo? > > For example [`96da5fe871/src/committee/onboarding/pr/dismiss_review.png`](https://forgejo.skynet.ie/Skynet/wiki/src/commit/96da5fe871d4d8c791c25438eca8593b2f2a9ce7/src/committee/onboarding/pr/dismiss_review.png) shows up as just its pointer But on yer onw its perfectly fine [`forgejo.skynet.ie/nanda/wiki/media@96da5fe871/src/committee/onboarding/pr/dismiss_review.png`](https://forgejo.skynet.ie/nanda/wiki/media/commit/96da5fe871d4d8c791c25438eca8593b2f2a9ce7/src/committee/onboarding/pr/dismiss_review.png) Fixed by adding the following string: > NOTE: To view LFS files (like images) in a PR, you need to open them from the source repository OR via the "Files Changed" tab on the PR.
silver commented 2026-03-28 23:45:46 +00:00
Owner
Copy link

Looks good, but only recommendation would be to change "Files Changed" to ``Files Changed``

Looks good, but only recommendation would be to change ``"Files Changed"`` to \`\`Files Changed\`\`
nanda requested review from silver 2026-03-28 23:45:47 +00:00
docs: replaced "" with ``
All checks were successful
/ check_lfs (pull_request) Successful in 2s
Details
1d1d0c15a2
nanda commented 2026-03-28 23:48:46 +00:00
Author
Owner
Copy link

@silver wrote in #43 (comment):

Looks good, but only recommendation would be to change "Files Changed" to Files Changed

Done.

@silver wrote in https://forgejo.skynet.ie/Skynet/wiki/pulls/43#issuecomment-3114: > Looks good, but only recommendation would be to change `"Files Changed"` to ``Files Changed`` Done.
silver approved these changes 2026-03-28 23:50:51 +00:00
silver merged commit 0e7e228fc5 into main 2026-03-28 23:50:56 +00:00
nanda commented 2026-03-28 23:55:47 +00:00
Author
Owner
Copy link

EPIC

EPIC
Sign in to join this conversation.
Reviewers
No reviewers
silver
Labels
Clear labels   
bug

   
documentation

   
duplicate

   
enhancement

   
good first issue

   
help wanted

   
invalid

   
question

   
wontfix
  
Trainee - Good First Issue

Something that is good for first issue

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Trainee - Good First Issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
nanda
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Skynet/wiki!43
No description provided.