Skynet/nixos
6
1
Fork 0
Code Issues 43 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Change spf and dmarc config #121

Merged
esy merged 7 commits from dmarc-spf-changes into main 2024-06-15 14:38:47 +00:00
Conversation 13 Commits 7 Files changed 1 +2 -2
esy commented 2024-06-15 12:32:02 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

If SPF Align fails it should get quarantined, this is currently not the case,
image

If SPF Align fails it should get quarantined, this is currently not the case, ![image](/uploads/e7e17ec6a73ad24941417072f853f52e/image.png)
esy commented 2024-06-15 12:50:43 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

mentioned in issue #78

mentioned in issue #78
silver commented 2024-06-15 13:30:20 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Oh this is what was allowing spf failures to get through?
Danm.

Oh this is what was allowing spf failures to get through? Danm.
esy commented 2024-06-15 13:30:54 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>1b848029 - fix host ip variable</li></ul> [Compare with previous version](/compsoc1/skynet/nixos/-/merge_requests/36/diffs?diff_id=543&start_sha=d3030aa2d1dd869030d1a9ab83e61403935fa03f)
esy commented 2024-06-15 13:32:26 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Im not sure it might be, i was under the impression that for SPF align as long as aspf was set to s it would quarantine anything that failed it, although it seems thats not the case.

Im not sure it might be, i was under the impression that for SPF align as long as aspf was set to s it would quarantine anything that failed it, although it seems thats not the case.
silver commented 2024-06-15 13:34:05 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Maybe try ${cfg.sub}.${cfg.domain} instead of mail.skynet.ie?
I am going to check up what include does befroe signing off on this

Maybe try ``${cfg.sub}.${cfg.domain}`` instead of ``mail.skynet.ie``? I am going to check up what ``include`` does befroe signing off on this
evanc commented 2024-06-15 13:36:26 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

The sp is for subdomains, so shouldn't allow completely different ones like ye were seeing

The sp is for subdomains, so shouldn't allow completely different ones like ye were seeing
esy commented 2024-06-15 13:42:42 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>149b58ce - use cfg variables</li></ul> [Compare with previous version](/compsoc1/skynet/nixos/-/merge_requests/36/diffs?diff_id=545&start_sha=1b848029e26f2a56d204ce2128fb16a4e6dd8ae3)
esy commented 2024-06-15 14:07:15 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e0a461bb - test</li></ul> [Compare with previous version](/compsoc1/skynet/nixos/-/merge_requests/36/diffs?diff_id=549&start_sha=149b58ce0978f562d78d27670b26a0be4f2c9478)
silver commented 2024-06-15 14:07:53 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

id say teh include:skynet.ie also isnt required since we dont send any mail from it

id say teh ``include:skynet.ie`` also isnt required since we dont send any mail from it
esy commented 2024-06-15 14:17:18 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 3 commits

  • e0a461bb...ed331c3f - 2 commits from branch compsoc1/skynet:main
  • 9e90553a - Merge branch nixos:main into dmarc-spf-changes

Compare with previous version

added 3 commits <ul><li>e0a461bb...ed331c3f - 2 commits from branch <code>compsoc1/skynet:main</code></li><li>9e90553a - Merge branch nixos:main into dmarc-spf-changes</li></ul> [Compare with previous version](/compsoc1/skynet/nixos/-/merge_requests/36/diffs?diff_id=551&start_sha=e0a461bb0aba734e08fa381b52488fa0c05f823a)
esy commented 2024-06-15 14:25:45 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>c0ddc2d6 - switch include to a, remove skynet.ie</li><li>5933cb5d - Revert &quot;test&quot;</li></ul> [Compare with previous version](/compsoc1/skynet/nixos/-/merge_requests/36/diffs?diff_id=553&start_sha=9e90553a6b86196a98c5e91b978015f3742ce7ca)
silver commented 2024-06-15 14:38:27 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

approved this merge request

approved this merge request
silver commented 2024-06-15 14:38:47 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

mentioned in commit 9b84ff8619

mentioned in commit 9b84ff86194e151c3f5fc28a450efe533ebf1819
silver (Migrated from gitlab.skynet.ie) merged commit 9b84ff8619 into main 2024-06-15 14:38:47 +00:00
silver (Migrated from gitlab.skynet.ie) approved these changes 2024-08-06 19:16:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
silver
Labels
Clear labels   
Draft

   
ITD Ticket

   
Improvement

   
Logging

   
Trainee

   
bugfix
No labels
Draft
ITD Ticket
Improvement
Logging
Trainee
bugfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Skynet/nixos#121
No description provided.
Delete branch "dmarc-spf-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?