Skynet/ldap_frontend
6
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Fix errors not being propogated to teh end user. #23

Merged
silver merged 10 commits from #9-not-correctly-showing-errors into main 2024-01-01 10:11:02 +00:00
Conversation 3 Commits 10 Files changed 18 +330 -341
silver commented 2024-01-01 10:10:52 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

The root cause of the error seen in #9 was that some res.json() were not being awaited.
The easiest way to fix this was to do a smol overhaul with a focus on standardization and de-duplication.

By seperating the JS out into their own files it allows IDE's to give us more powerful tools to play with while also giving us better tools to work with (modules/importing)

Closes #9

The root cause of the error seen in #9 was that some ``res.json()`` were not being awaited. The easiest way to fix this was to do a smol overhaul with a focus on standardization and de-duplication. By seperating the JS out into their own files it allows IDE's to give us more powerful tools to play with while also giving us better tools to work with (modules/importing) Closes #9
silver commented 2024-01-01 10:10:52 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

assigned to @silver

assigned to @silver
silver commented 2024-01-01 10:10:56 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

approved this merge request

approved this merge request
silver commented 2024-01-01 10:11:02 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

mentioned in commit d3b4c822b9

mentioned in commit d3b4c822b9782b5c072269d18844ec6461c0fe86
silver (Migrated from gitlab.skynet.ie) merged commit d3b4c822b9 into main 2024-01-01 10:11:02 +00:00
silver (Migrated from gitlab.skynet.ie) approved these changes 2024-08-08 14:26:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
silver
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Skynet/ldap_frontend#23
No description provided.
Delete branch "#9-not-correctly-showing-errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?