Skynet/ldap_frontend
6
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Frontend for new SSH page #22

Merged
esy merged 21 commits from #7-multiple-ssh-keys into main 2024-02-18 17:28:21 +00:00
Conversation 71 Commits 21 Files changed 12 +272 -36
esy commented 2023-12-31 00:25:41 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Might need some final testing/changes
Closes #7

Might need some final testing/changes Closes #7
silver commented 2023-12-31 07:09:26 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Going to give a review of this.
We know that it works fine so mostly formatting and naming

Going to give a review of this. We know that it works fine so mostly formatting and naming
esy commented 2023-12-31 07:09:37 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

  • 9b9ea812 - fix : removed testing api endpoints with actual

Compare with previous version

added 1 commit <ul><li>9b9ea812 - fix : removed testing api endpoints with actual</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=379&start_sha=128794648c3b918f068962cb4a48330b5a2e04df)
silver commented 2023-12-31 07:24:52 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

This is just a suggestion but I tend to go for $common_$identifier in my vars, so in this case it would be:

    let cell_name = new_row.insertCell(0);
    let cell_key= new_row.insertCell(1);

This way its very easy to see related vars (this is mostly based on the fact that we read left to right)

This is just a suggestion but I tend to go for ``$common_$identifier`` in my vars, so in this case it would be: ``` let cell_name = new_row.insertCell(0); let cell_key= new_row.insertCell(1); ``` This way its very easy to see related vars (this is mostly based on the fact that we read left to right)
silver commented 2023-12-31 07:31:17 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Another option isntead of this would be to call function get_keys() here, to always ensure that the keys displayed here match teh database)

Another option isntead of this would be to call ``function get_keys()`` here, to always ensure that the keys displayed here match teh database)
silver commented 2023-12-31 07:31:25 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Id say reduce the newlines here

Id say reduce the newlines here
silver commented 2023-12-31 07:31:25 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Is this really needed?
Ideally each function has no external state like this.

Is this really needed? Ideally each function has no external state like this.
silver commented 2023-12-31 07:31:25 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Address will need to be updated

Address will need to be updated
silver commented 2023-12-31 07:31:25 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Could it be worth returning early?

if (response.status != 200) {
  document.getElementById('formStatus').innerHTML = "<span style='background-color: red; color: white'>Failed to fetch</span>";
  return;
}

Returning early helps to reduce nesting

Could it be worth returning early? ```javascript if (response.status != 200) { document.getElementById('formStatus').innerHTML = "<span style='background-color: red; color: white'>Failed to fetch</span>"; return; } ``` Returning early helps to reduce nesting
silver commented 2023-12-31 07:31:25 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Could be worth displaying the error:

- document.getElementById('formStatus').innerHTML = "<span style='background-color: red; color: white'>Error: Failed to get keys</span>";
+ document.getElementById('formStatus').innerHTML = `<span style='background-color: red; color: white'>Error: ${data.error}</span>`;

This lets the backend set the message

Could be worth displaying the error: ```diff - document.getElementById('formStatus').innerHTML = "<span style='background-color: red; color: white'>Error: Failed to get keys</span>"; + document.getElementById('formStatus').innerHTML = `<span style='background-color: red; color: white'>Error: ${data.error}</span>`; ``` This lets the backend set the message
silver commented 2023-12-31 07:31:25 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

You could have a call to a function in here to delete and re-create the table, making it ready for the keys.

You could have a call to a function in here to delete and re-create the table, making it ready for the keys.
silver commented 2023-12-31 07:31:26 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Same as above

Same as above
silver commented 2023-12-31 07:31:26 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Again consider returning early to reduce nesting (like ye actually have on line 41)

Again consider returning early to reduce nesting (like ye actually have on line 41)
silver commented 2023-12-31 07:31:26 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Again, same as above

Again, same as above
silver commented 2023-12-31 07:31:26 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

maybe just call this row?

maybe just call this ``row``?
silver commented 2023-12-31 07:31:26 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

A more egronomic way of doign this would be

-    let key_string = key_split[0] + ' ' + key_split[1];
+    let key_string = `${key_split[0]} ${key_split[1]}`;

Basically this creates teh string directly instead of adding 3 strings together.

A more egronomic way of doign this would be ```diff - let key_string = key_split[0] + ' ' + key_split[1]; + let key_string = `${key_split[0]} ${key_split[1]}`; ``` Basically this creates teh string directly instead of adding 3 strings together.
silver commented 2023-12-31 07:31:26 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

if some of the previous recommendations are taken (such as deleting and recreating teh table in "get keys") then this shouldnt be nessessary, right?

if some of the previous recommendations are taken (such as deleting and recreating teh table in "get keys") then this shouldnt be nessessary, right?
silver commented 2023-12-31 07:35:25 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Seems ye pushed this patch out while I was reviewing

Seems ye pushed this patch out while I was reviewing
esy commented 2023-12-31 08:18:38 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=381&start_sha=9b9ea81206315d168133b86058ac4fc481fabc6e#87514a9bbaf291dd0c749416162d18f4e8f291ab_102_102)
esy commented 2023-12-31 08:18:38 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=381&start_sha=9b9ea81206315d168133b86058ac4fc481fabc6e#87514a9bbaf291dd0c749416162d18f4e8f291ab_56_51)
esy commented 2023-12-31 08:18:38 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=381&start_sha=9b9ea81206315d168133b86058ac4fc481fabc6e#f9dd74b10cb20d73eeab99058999be0030145979_24_25)
esy commented 2023-12-31 08:18:39 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=381&start_sha=9b9ea81206315d168133b86058ac4fc481fabc6e#87514a9bbaf291dd0c749416162d18f4e8f291ab_14_13)
esy commented 2023-12-31 08:18:39 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=381&start_sha=9b9ea81206315d168133b86058ac4fc481fabc6e#87514a9bbaf291dd0c749416162d18f4e8f291ab_25_13)
esy commented 2023-12-31 08:18:39 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=381&start_sha=9b9ea81206315d168133b86058ac4fc481fabc6e#87514a9bbaf291dd0c749416162d18f4e8f291ab_17_13)
esy commented 2023-12-31 08:18:39 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=381&start_sha=9b9ea81206315d168133b86058ac4fc481fabc6e#87514a9bbaf291dd0c749416162d18f4e8f291ab_51_51)
esy commented 2023-12-31 08:18:39 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=381&start_sha=9b9ea81206315d168133b86058ac4fc481fabc6e#87514a9bbaf291dd0c749416162d18f4e8f291ab_100_102)
esy commented 2023-12-31 08:18:39 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=381&start_sha=9b9ea81206315d168133b86058ac4fc481fabc6e#87514a9bbaf291dd0c749416162d18f4e8f291ab_106_108)
esy commented 2023-12-31 08:18:39 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

  • 202c89ca - fix : early return, logging errors into frontend

Compare with previous version

added 1 commit <ul><li>202c89ca - fix : early return, logging errors into frontend</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=381&start_sha=9b9ea81206315d168133b86058ac4fc481fabc6e)
esy commented 2023-12-31 08:20:05 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Wouldn't this make allow for unnecessary calls to the api, when only one is needed. Remaking the table every time is also wasteful albeit not that much but still something. Imo some state > loss of performance.

Wouldn't this make allow for unnecessary calls to the api, when only one is needed. Remaking the table every time is also wasteful albeit not that much but still something. Imo some state > loss of performance.
silver commented 2023-12-31 08:24:48 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Ye this is just a suggestion, there are pros and cons to both approaches (part of why I asked teh question was to make ye aware of it)

Ye this is just a suggestion, there are pros and cons to both approaches (part of why I asked teh question was to make ye aware of it)
esy commented 2023-12-31 08:28:52 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

If your okay with keeping state, would prefer to keep this here. Some of it could be moved into the function but I think its better to keep it next to the listener and avoid calling the function to check.

If your okay with keeping state, would prefer to keep this here. Some of it could be moved into the function but I think its better to keep it next to the listener and avoid calling the function to check.
silver commented 2023-12-31 08:31:21 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Yep (kinda the stange area of it being state and at the same time not state)

Yep (kinda the stange area of it being state and at the same time not state)
silver commented 2023-12-31 08:33:49 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

(and newlines incresed?)

Was thinkin g more like this

       table, th{
            border: 1px solid;
        }
(and newlines incresed?) Was thinkin g more like this ```diff table, th{ border: 1px solid; } ```
esy commented 2023-12-31 08:35:21 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c6e07144 - fmt : newline</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=383&start_sha=202c89ca7421d3ede9cb7c4b3e670507258d3c6b)
esy commented 2023-12-31 08:39:33 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

sorry(the formatter made me do it), fixed now

sorry(the formatter made me do it), fixed now
esy commented 2023-12-31 08:48:05 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Tested everything again with mockoon, seems to be good. Might some more testing with the actual LDAP & backend server.

Tested everything again with mockoon, seems to be good. Might some more testing with the actual LDAP & backend server.
esy commented 2024-01-01 16:55:13 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 12 commits

Compare with previous version

added 12 commits <ul><li>c6e07144...d3b4c822 - 11 commits from branch <code>compsoc1/skynet/ldap:main</code></li><li>a12bd3e0 - Merge branch &#39;main&#39; of https://gitlab.skynet.ie/compsoc1/skynet/ldap/frontend...</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=388&start_sha=c6e071448536783c984c35dcbcdb493947c57beb)
esy commented 2024-01-01 17:03:29 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=389&start_sha=a12bd3e0403e7862c40e5deb028a3ff309ba5966#87514a9bbaf291dd0c749416162d18f4e8f291ab_1_0)
esy commented 2024-01-01 17:03:29 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 6 of the diff

changed this line in [version 6 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=389&start_sha=a12bd3e0403e7862c40e5deb028a3ff309ba5966#87514a9bbaf291dd0c749416162d18f4e8f291ab_135_0)
esy commented 2024-01-01 17:03:29 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

  • 7100dad7 - fix : moved ssh stuff int src/

Compare with previous version

added 1 commit <ul><li>7100dad7 - fix : moved ssh stuff int src/</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=389&start_sha=a12bd3e0403e7862c40e5deb028a3ff309ba5966)
esy commented 2024-01-01 17:04:13 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

resolved all threads

resolved all threads
esy commented 2024-01-01 17:16:57 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 2 commits

  • 7c2a3e64 - fix : now can catch any errors thrown by awaiting req.json()
  • cb806ad8 - fix : rename ssh.js

Compare with previous version

added 2 commits <ul><li>7c2a3e64 - fix : now can catch any errors thrown by awaiting req.json()</li><li>cb806ad8 - fix : rename ssh.js</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=391&start_sha=7100dad705ee2b929b0f46f15ff04b2b821a90f8)
silver commented 2024-01-01 17:43:52 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

could ye remove the ssh option from the modify.html page?

and for the lib.js seems like a lot of changes, ye sure git picked up that it was whitespace changes?

could ye remove the ssh option from the modify.html page? and for the lib.js seems like a lot of changes, ye sure git picked up that it was whitespace changes?
esy commented 2024-01-01 18:01:54 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

  • c215c710 - fix : remove ssh from modify page , added ssh page to index.html

Compare with previous version

added 1 commit <ul><li>c215c710 - fix : remove ssh from modify page , added ssh page to index.html</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=393&start_sha=cb806ad893c89d44bb3b9f46f7067267b8ba0344)
esy commented 2024-01-01 18:04:58 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

and for the lib.js seems like a lot of changes, ye sure git picked up that it was whitespace changes? - unsure what this means, this is what lib.js looks like now.

`and for the lib.js seems like a lot of changes, ye sure git picked up that it was whitespace changes?` - unsure what this means, [this](https://gitlab.skynet.ie/esy/frontend/-/blob/%237-multiple-ssh-keys/src/js/lib.js) is what lib.js looks like now.
silver commented 2024-01-01 18:06:13 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

I am going off of https://gitlab.skynet.ie/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs#diff-content-51615cdbd65f5e0f94e679f596b05006d3cfee15

I am going off of https://gitlab.skynet.ie/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs#diff-content-51615cdbd65f5e0f94e679f596b05006d3cfee15
esy commented 2024-01-01 18:36:58 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

  • 5f11bbce - feat : changed post_request to be more general and return true/false based on response

Compare with previous version

added 1 commit <ul><li>5f11bbce - feat : changed post_request to be more general and return true/false based on response</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=395&start_sha=c215c710b9088ea9626b3e8a1859749098316184)
esy commented 2024-01-01 19:00:27 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Whats wrong with it?

Whats wrong with it?
silver commented 2024-01-01 19:11:24 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Just home so can actually see it on computer.

See how there is a huge red and green block?
With teh contents near identical?
image

It is often best if thesse are avoided as it cna make going back through teh history tos ee why a change happened harder.

Why it happened here was because you made too many non-whitespace changes (and also introduced some possible bugs in the process).

So if ye replace it with (exactly (aside from indentation)) this:



export async function post_request(url, body, form_status){
    try {
        const req = await fetch(url, {
            method: 'POST',
            body: JSON.stringify(body),
            mode: "cors"
        });
    if (req.status !== 200) {
        form_status.innerHTML = "<span style='background-color: red; color: white'>Failure</span>";
        return false;
    }

    let temp = await req.json();
    if (temp.result === 'error') {
        form_status.innerHTML = `<span style='background-color: red; color: white'>${temp.error}</span>`;
        return false;
    } else {
        form_status.innerHTML = "<span style='background-color: green; color: white'>Success</span>";
        return true;
    }
    } catch (e) {
        form_status.innerHTML = `<span style='background-color: red; color: white'>${e}</span>`;
        return false;
    }
}
Just home so can actually see it on computer. See how there is a huge red and green block? With teh contents near identical? ![image](/uploads/39c28f903a06e90c93ac23bab970efc5/image.png) It is often best if thesse are avoided as it cna make going back through teh history tos ee why a change happened harder. Why it happened here was because you made too many non-whitespace changes (and also introduced some possible bugs in the process). So if ye replace it with (exactly (aside from indentation)) this: ```javascript export async function post_request(url, body, form_status){ try { const req = await fetch(url, { method: 'POST', body: JSON.stringify(body), mode: "cors" }); if (req.status !== 200) { form_status.innerHTML = "<span style='background-color: red; color: white'>Failure</span>"; return false; } let temp = await req.json(); if (temp.result === 'error') { form_status.innerHTML = `<span style='background-color: red; color: white'>${temp.error}</span>`; return false; } else { form_status.innerHTML = "<span style='background-color: green; color: white'>Success</span>"; return true; } } catch (e) { form_status.innerHTML = `<span style='background-color: red; color: white'>${e}</span>`; return false; } } ```
silver commented 2024-01-01 19:13:18 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

if (req.status !== 200) { to just above } catch (e) { should eb indented.
By doing so I am pretty sure the diff will be more concise

``if (req.status !== 200) {`` to just above ``} catch (e) {`` should eb indented. By doing so I am pretty sure the diff will be more concise
silver commented 2024-01-10 05:12:20 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

This will cause issues with L55

This will cause issues with L55
silver commented 2024-01-10 05:12:20 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Still not fond of this.

Take a look at https://gitlab.skynet.ie/compsoc1/skynet/ldap/frontend/-/blob/main/src/signup.js?ref_type=heads
Ye can see how events are attached. (L3-L4)

Also this will also block the user from getting data from teh source of truth (backend).
Say for example they submit a key, the local table is updated but something happens in the backend that it dosent get added to the database.
But because the table gets updated here the user thinks that its all fine.
That is an edge case I would rather avoid.

If ye would rather not having to do anotehr get request after adding/deleting then it could be worth modifying the backend to return an array of all valid keys on sucessful modification.
That would mean on L45,L64 here ye could use the return value, delete the table and recreate it.

Still not fond of this. Take a look at https://gitlab.skynet.ie/compsoc1/skynet/ldap/frontend/-/blob/main/src/signup.js?ref_type=heads Ye can see how events are attached. (L3-L4) Also this will also block the user from getting data from teh source of truth (backend). Say for example they submit a key, the local table is updated but something happens in the backend that it dosent get added to the database. But because the table gets updated here the user thinks that its all fine. That is an edge case I would rather avoid. If ye would rather not having to do anotehr get request after adding/deleting then it could be worth modifying the backend to return an array of all valid keys on sucessful modification. That would mean on L45,L64 here ye could use the return value, delete the table and recreate it.
esy commented 2024-01-10 08:38:41 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Say for example they submit a key, the local table is updated but something happens in the backend that it dosent get added to the database. But because the table gets updated here the user thinks that its all fine. That is an edge case I would rather avoid.

The code highlighted here isnt how the key actually gets added unless im misunderstanding, key only gets added when it returns true/success, so this edge case doesnt exist unless im misunderstanding your example.

`Say for example they submit a key, the local table is updated but something happens in the backend that it dosent get added to the database. But because the table gets updated here the user thinks that its all fine. That is an edge case I would rather avoid.` The code highlighted here isnt how the key actually gets added unless im misunderstanding, key only gets added when it returns [true/success](https://gitlab.skynet.ie/esy/frontend/-/blob/%237-multiple-ssh-keys/src/modify_ssh.js?ref_type=heads#L45), so this edge case doesnt exist unless im misunderstanding your example.
esy commented 2024-01-10 08:41:56 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Yeah i think this could easily be solved with some more state(dictionary), re constructing the keys might be a bit hard. Will have to look into it more in a few days, bit busy rn.

Yeah i think this could easily be solved with some more state(dictionary), re constructing the keys might be a bit hard. Will have to look into it more in a few days, bit busy rn.
silver commented 2024-01-10 08:42:22 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

User presses the button a second time, data in the table remains unchanged (because the update is blocked by the flag)

Basically you are assuming that the local state matches the backend, I am pointing out that that assumption may be false.

User presses the button a second time, data in the table remains unchanged (because the update is blocked by the flag) Basically you are assuming that the local state matches the backend, I am pointing out that that assumption may be false.
silver commented 2024-01-10 08:52:27 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Ye could always have the fullkey as the ID of the row or something, or even embedded in the delete button like on https://gitlab.skynet.ie/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs#a9b67728c126b35b94bb66c258c6ffb01ae64cbe_0_93 ye could have a second parm there that is the key, passed in directly

Ye could always have the fullkey as the ID of the row or something, or even embedded in the delete button like on https://gitlab.skynet.ie/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs#a9b67728c126b35b94bb66c258c6ffb01ae64cbe_0_93 ye could have a second parm there that is the key, passed in directly
silver commented 2024-01-10 09:15:13 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

The reason why I say that line specifically is because that function has the pure, unaltered key, splitting it apart and rejoining it isnt perfect (and makes its pwn assumptions that each key will have a comment)

Fun fact, the keys can be in the format of command="link to script" ssh-rsa AAAAAAAAAAAA comment

The reason why I say that line specifically is because that function has the pure, unaltered key, splitting it apart and rejoining it isnt perfect (and makes its pwn assumptions that each key will have a comment) Fun fact, the keys can be in the format of ``command="link to script" ssh-rsa AAAAAAAAAAAA comment``
silver commented 2024-01-10 11:26:14 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

mentioned in commit backend@96f86985eec772a835e7867852ee6452fd9548b6

mentioned in commit backend@96f86985eec772a835e7867852ee6452fd9548b6
esy commented 2024-02-18 02:46:18 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

  • dcbce994 - Table now refreshes after deleting / adding key

Compare with previous version

added 1 commit <ul><li>dcbce994 - Table now refreshes after deleting / adding key</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=408&start_sha=5f11bbce09e2e8c27fa5910f156fc52985454ee5)
esy commented 2024-02-18 02:47:14 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Should be resolved now

Should be resolved now
esy commented 2024-02-18 02:47:35 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Added keys as attribute fixed this atleast in my testing so far.

Added keys as attribute fixed this atleast in my testing so far.
esy commented 2024-02-18 13:32:44 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>318b4136 - fix : correct api endpoints</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=411&start_sha=dcbce9942b8172a97efcbe28fbdaedae5bda473d)
esy commented 2024-02-18 13:34:36 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>e4a48864 - fix : trailing slash</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=413&start_sha=318b4136b0137777713866e32b15918c7fdaba08)
silver commented 2024-02-18 15:52:33 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

resolved all threads

resolved all threads
silver commented 2024-02-18 15:53:47 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Code looks good now.

Main final thing is formatting.
Maybe add word wrap on the keys so it dosent go off screen.
Also ad a bit of a margin to all text in the table so its not banging up against the cell wall.

Code looks good now. Main final thing is formatting. Maybe add word wrap on the keys so it dosent go off screen. Also ad a bit of a margin to all text in the table so its not banging up against the cell wall.
esy commented 2024-02-18 16:30:22 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>0851e993 - fix : styling and word wrap</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=416&start_sha=e4a48864ad69ec743db96c6ca34b2b4bd70cb9a2)
esy commented 2024-02-18 16:47:31 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

  • 92a83a20 - fmt , made default textarea bigger

Compare with previous version

added 1 commit <ul><li>92a83a20 - fmt , made default textarea bigger</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/12/diffs?diff_id=418&start_sha=0851e9934d3e5f81891b87486101cd13aa1e41a5)
esy commented 2024-02-18 16:49:46 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Should be resolved now ☕

Should be resolved now :coffee:
silver commented 2024-02-18 17:06:38 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

resolved all threads

resolved all threads
silver commented 2024-02-18 17:27:59 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

All looks good to me

All looks good to me
silver commented 2024-02-18 17:28:06 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

approved this merge request

approved this merge request
silver (Migrated from gitlab.skynet.ie) merged commit 36c5e5bbae into main 2024-02-18 17:28:21 +00:00
silver commented 2024-02-18 17:28:22 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

mentioned in commit 36c5e5bbae

mentioned in commit 36c5e5bbae7adcc404bec6d643cae5fd8a6c87bb
silver (Migrated from gitlab.skynet.ie) approved these changes 2024-08-08 14:26:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
silver
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Skynet/ldap_frontend#22
No description provided.
Delete branch "#7-multiple-ssh-keys"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?