Skynet/ldap_frontend
6
0
Fork 1
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

Resolve "[New users] Sign-up" #16

Merged
eoghanconlon73 merged 14 commits from 3-new-users-sign-up into main 2023-09-03 21:19:31 +00:00
Conversation 20 Commits 14 Files changed 3 +90 -2
eoghanconlon73 commented 2023-08-07 18:53:33 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

New sign-up page has been implemented

Closes #3

New sign-up page has been implemented Closes #3
eoghanconlon73 commented 2023-09-02 18:16:19 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Sign-up works, Register untested at the moement

Sign-up works, Register untested at the moement
eoghanconlon73 commented 2023-09-03 18:00:05 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Register in an unknown state at the moment, possibly an issue on the backend?

Register in an unknown state at the moment, possibly an issue on the backend?
eoghanconlon73 commented 2023-09-03 19:01:46 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

  • 38d79217 - Adding loader to the formStatus paragraph on submit button press.

Compare with previous version

added 1 commit <ul><li>38d79217 - Adding loader to the formStatus paragraph on submit button press.</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/6/diffs?diff_id=145&start_sha=050fd480fb702307940582a37091f91a8bf62d5f)
eoghanconlon73 commented 2023-09-03 19:35:58 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

requested review from @eoghanconlon73

requested review from @eoghanconlon73
eoghanconlon73 commented 2023-09-03 19:36:06 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

removed review request for @eoghanconlon73

removed review request for @eoghanconlon73
eoghanconlon73 commented 2023-09-03 19:36:14 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

assigned to @eoghanconlon73

assigned to @eoghanconlon73
eoghanconlon73 commented 2023-09-03 19:36:34 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

All working ready for review

All working ready for review
silver commented 2023-09-03 19:41:06 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

What ye mean by this?

What ye mean by this?
silver commented 2023-09-03 19:43:20 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

What is with this strange spacing?

What is with this strange spacing?
eoghanconlon73 commented 2023-09-03 19:52:34 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

I have yet to run standardization on this yet, will fix now

I have yet to run standardization on this yet, will fix now
eoghanconlon73 commented 2023-09-03 19:55:03 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>456861c5 - Fix. Spacing</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/6/diffs?diff_id=147&start_sha=38d79217d95c398f0e6d55aa6b28646bbb3983ef)
eoghanconlon73 commented 2023-09-03 19:56:08 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Should be fixed now

Should be fixed now
eoghanconlon73 commented 2023-09-03 19:56:45 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Think I was having a different problem there

Think I was having a different problem there
silver commented 2023-09-03 20:13:17 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

Take another look at teh lines mentioned

Take another look at teh lines mentioned
eoghanconlon73 commented 2023-09-03 21:16:36 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

changed this line in version 4 of the diff

changed this line in [version 4 of the diff](/compsoc1/skynet/ldap/frontend/-/merge_requests/6/diffs?diff_id=149&start_sha=456861c5df1bb39977c90ccb01b889616ef0ccc5#5a0f331bf1b904f45746df70b43641abf56e10c0_47_43)
eoghanconlon73 commented 2023-09-03 21:16:37 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

added 2 commits

Compare with previous version

added 2 commits <ul><li>5be10a57 - Fix. Spacing</li><li>ddd41636 - Password length checked</li></ul> [Compare with previous version](/compsoc1/skynet/ldap/frontend/-/merge_requests/6/diffs?diff_id=149&start_sha=456861c5df1bb39977c90ccb01b889616ef0ccc5)
silver commented 2023-09-03 21:19:00 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

resolved all threads

resolved all threads
silver commented 2023-09-03 21:19:09 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

approved this merge request

approved this merge request
silver commented 2023-09-03 21:19:31 +00:00 (Migrated from gitlab.skynet.ie)
Copy link

mentioned in commit 947124c3b6

mentioned in commit 947124c3b65cb76257d3e5e74adbd695ef581c53
silver (Migrated from gitlab.skynet.ie) merged commit 947124c3b6 into main 2023-09-03 21:19:31 +00:00
silver (Migrated from gitlab.skynet.ie) approved these changes 2024-08-08 14:26:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
silver
Labels
Clear labels
  
Trainee - Good First Issue

Something that is good for first issue

No labels
Trainee - Good First Issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Skynet/ldap_frontend!16
No description provided.