Skynet/discord-bot
6
1
Fork 4
Code Issues 4 Pull requests 3 Projects Releases Packages Wiki Activity Actions

main #47

Open
amymucko wants to merge 2 commits from amymucko/discord-bot:main into main
pull from: amymucko/discord-bot:main
merge into: Skynet:main
Conversation 2 Commits 2 Files changed 1 +11 -8
amymucko commented 2025-09-22 20:19:39 +00:00
First-time contributor
Copy link

Some minor changes to language

Some minor changes to language
Cleaned up the language a lil
Update doc/User.md
All checks were successful
/ check_lfs (pull_request) Successful in 7s
Details
/ lint_fmt (pull_request) Successful in 29s
Details
/ lint_clippy (pull_request) Successful in 1m24s
Details
/ build (pull_request) Successful in 1m41s
Details
d98c4d195c 
Spacing?
silver requested changes 2025-09-22 20:24:39 +00:00
silver left a comment
Owner
Copy link

Mostly good

Mostly good
doc/User.md
@ -11,3 +11,2 @@
1. In a Discord server with the Skynet Bot enter ``/wolves link YOUR_WOLVES_CONTACT_EMAIL``
1. In a Discord server with the Skynet Bot enter ``/wolves link YOUR_WOLVES_CONTACT_EMAIL``
<img src="../media/setup_user_01.png" alt="link process start" width="50%" height="50%">
* Your ``YOUR_WOLVES_CONTACT_EMAIL`` is the email in the Contact Email here: <https://ulwolves.ie/memberships/profile>
silver commented 2025-09-22 20:22:55 +00:00
Owner
Copy link

Its literally called (preferred) Contact Email on Wolves so this makes it more confusing

Its literally called (preferred) ``Contact Email`` on Wolves so this makes it more confusing
amymucko commented 2025-09-22 20:28:08 +00:00
Author
First-time contributor
Copy link

"is your Contact Email for ULWolves, found here"?

"is your Contact Email for ULWolves, found here"?
👍 1
silver commented 2025-09-22 20:30:29 +00:00
Owner
Copy link

That works

That works
silver marked this conversation as resolved
doc/User.md
@ -2,3 +2,1 @@
The Skynet bot is designed to make it easy to verify that you are a member of a Club/Society.
The bot will be able to give you member roles for any partnered servers.
It also provides secondary manifests such as granting access to minecraft servers managed by teh Computer Society.
The Skynet bot is designed to connect your ULWolves and committee roles to your discord.
silver commented 2025-09-22 20:24:10 +00:00
Owner
Copy link
  1. For more than just Committee.
  2. Does not make much grammatical sense
    • Connects Wolves and Discord account
1. For more than just Committee. 2. Does not make much grammatical sense * Connects Wolves and Discord account
amymucko commented 2025-09-22 20:30:23 +00:00
Author
First-time contributor
Copy link

"is designed to connect your ULWolves account and/or any committee roles you have to your discord." ?

"is designed to connect your ULWolves account and/or any committee roles you have to your discord." ?
silver commented 2025-09-22 20:33:26 +00:00
Owner
Copy link
- and/or any committee roles you have

The roles is a follow on part

```diff - and/or any committee roles you have ``` The roles is a follow on part
amymucko commented 2025-09-22 20:36:38 +00:00
Author
First-time contributor
Copy link

what do you mean by that?

what do you mean by that?
silver commented 2025-09-22 20:39:21 +00:00
Owner
Copy link

its a two part process

the main thing is linking Wolves and Discord
managing roles just is using that data

If ye put in and/or any committee roles you have then ye will confuse teh fuck out of anyone who isnt a committee member trying to use it.
Unless ye add and/or any committee and member roles on select discords roles you have which would make it more clear, but unwieldy.

its a two part process the main thing is linking Wolves and Discord managing roles just is using that data If ye put in ``and/or any committee roles you have`` then ye will confuse teh fuck out of anyone who isnt a committee member trying to use it. Unless ye add ``and/or any committee and member roles on select discords roles you have`` which would make it more clear, but unwieldy.
amymucko commented 2025-09-22 20:46:45 +00:00
Author
First-time contributor
Copy link

aight so maybe keep it in two sentences?
"The Skynet Bot is designed to verify your membership of a club/society and connect your ULWolves Account to your Discord.
It will also link any committee role(s) you have."

aight so maybe keep it in two sentences? "The Skynet Bot is designed to verify your membership of a club/society and connect your ULWolves Account to your Discord. It will also link any committee role(s) you have."
silver commented 2025-09-22 20:52:21 +00:00
Owner
Copy link

How about something like this?

The Skynet Bot is designed to connect your ULWolves Account to your Discord.  
This:
1. Verifys you are on a committee for the Committee server
2. Gives you the ``member`` roles for any partnered servers.
3. Granting access to Minecraft servers managed by teh Computer Society.
How about something like this? ```markdown The Skynet Bot is designed to connect your ULWolves Account to your Discord. This: 1. Verifys you are on a committee for the Committee server 2. Gives you the ``member`` roles for any partnered servers. 3. Granting access to Minecraft servers managed by teh Computer Society. ```
amymucko commented 2025-09-22 20:57:36 +00:00
Author
First-time contributor
Copy link

thats good I think

thats good I think
silver commented 2025-09-22 21:01:32 +00:00
Owner
Copy link

any partnered servers. dosent sit quite right with me though, so feel free to change it to somethign ye think works best.

``any partnered servers.`` dosent sit quite right with me though, so feel free to change it to somethign ye think works best.
amymucko commented 2025-09-22 21:04:55 +00:00
Author
First-time contributor
Copy link

"for any server of which whose club/society you are a member"

"for any server of which whose club/society you are a member"
silver commented 2025-09-22 21:11:48 +00:00
Owner
Copy link

sounds good

sounds good
silver reviewed 2025-09-22 20:34:31 +00:00
doc/User.md
@ -8,4 +8,3 @@
**You will only need to do this once**.
### Setup
1. In a Discord server with the Skynet Bot enter ``/wolves link YOUR_WOLVES_CONTACT_EMAIL``
silver commented 2025-09-22 20:34:31 +00:00
Owner
Copy link

I know it seems strange, but this space needs to go back, removing it will feck up the formatting

I know it seems strange, but this space needs to go back, removing it will feck up the formatting
silver commented 2025-09-22 20:35:55 +00:00
Owner
Copy link

Not clear from just above, but the end of this line needs two spaces

Not clear from just above, but the end of this line needs two spaces
silver marked this conversation as resolved
All checks were successful
/ check_lfs (pull_request) Successful in 7s
Details
/ lint_fmt (pull_request) Successful in 29s
Details
/ lint_clippy (pull_request) Successful in 1m24s
Details
/ build (pull_request) Successful in 1m41s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:amymucko-main
git switch amymucko-main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff amymucko-main
git switch amymucko-main
git rebase main
git switch main
git merge --ff-only amymucko-main
git switch amymucko-main
git rebase main
git switch main
git merge --no-ff amymucko-main
git switch main
git merge --squash amymucko-main
git switch main
git merge --ff-only amymucko-main
git switch main
git merge amymucko-main
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
silver
Labels
Clear labels
  
Trainee - Good First Issue

Something that is good for first issue

No labels
Trainee - Good First Issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Skynet/discord-bot#47
No description provided.
Delete branch "amymucko/discord-bot:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?