Skynet/actions
6
0
Fork 1
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Adding action to add nix capabilities to docker runner #2

Open
eoghanconlon73 wants to merge 20 commits from eoghanconlon73/actions:main into main
pull from: eoghanconlon73/actions:main
merge into: Skynet:main
Conversation 5 Commits 20 Files changed 4 +61 -1
eoghanconlon73 commented 2024-09-30 20:28:12 +00:00
First-time contributor
Copy link
No description provided.
eoghanconlon73 added 3 commits 2024-09-30 20:28:12 +00:00
eoghanconlon73 commented 2024-09-30 20:28:48 +00:00
Author
First-time contributor
Copy link

The action works, tested: https://forgejo.skynet.ie/eoghanconlon73/website_test/actions/runs/15

The action works, tested: https://forgejo.skynet.ie/eoghanconlon73/website_test/actions/runs/15
eoghanconlon73 requested review from silver 2024-09-30 20:30:03 +00:00
eoghanconlon73 commented 2024-09-30 20:31:01 +00:00
Author
First-time contributor
Copy link

Can be tested with: https://forgejo.skynet.ie/eoghanconlon73/actions/docker_nix@eoghan_testV2

Can be tested with: https://forgejo.skynet.ie/eoghanconlon73/actions/docker_nix@eoghan_testV2
eoghanconlon73 commented 2024-09-30 20:46:15 +00:00
Author
First-time contributor
Copy link

Just after realising, I never signed off on any of the commits, sorry about that

Just after realising, I never signed off on any of the commits, sorry about that
silver requested changes 2024-10-01 08:21:42 +00:00
README.md Outdated
@ -107,0 +113,4 @@
build:
runs-on: docker
steps:
uses: https://forgejo.skynet.ie/Skynet/actions/docker_nix@vx
silver commented 2024-10-01 08:21:18 +00:00
Owner
Copy link

Id say just set it to be v7, since that is what I will be tagging it with

Id say just set it to be ``v7``, since that is what I will be tagging it with
eoghanconlon73 commented 2024-10-01 08:52:16 +00:00
Author
First-time contributor
Copy link

Perfect, was more leaving it as generic as I wanted to have one change at the end for the version

Perfect, was more leaving it as generic as I wanted to have one change at the end for the version
docker_nix/action.yml Outdated
@ -0,0 +3,4 @@
runs:
using: 'composite'
steps:
- name: 'Get image ready to run nix jobs'
silver commented 2024-10-01 08:15:50 +00:00
Owner
Copy link

It is more that sudo is required for the installer to run.

It is more that ``sudo`` is required for the installer to run.
👍 1
docker_nix/action.yml Outdated
@ -0,0 +11,4 @@
apt install sudo
- uses: https://github.com/cachix/install-nix-action@v29
with:
nix_path: nixpkgs=channel:nixos-unstable
silver commented 2024-10-01 08:19:48 +00:00
Owner
Copy link

What if someone wants to specify what version of nix to use?

The inputs fot teh install-nix-action can be found here: https://github.com/cachix/install-nix-action?tab=readme-ov-file#inputs-specify-using-with

(I honestly dont think anyone would really use this, more food to think for the future (we can revisit if someone needs it))

What if someone wants to specify what version of nix to use? The inputs fot teh install-nix-action can be found here: https://github.com/cachix/install-nix-action?tab=readme-ov-file#inputs-specify-using-with (I honestly dont think anyone would really use this, more food to think for the future (we can revisit if someone needs it))
eoghanconlon73 commented 2024-10-01 08:53:09 +00:00
Author
First-time contributor
Copy link

perfect, I'll have a look into this there in a few minutes

perfect, I'll have a look into this there in a few minutes
eoghanconlon73 commented 2024-10-01 09:08:48 +00:00
Author
First-time contributor
Copy link

This didn't work as I expected, it still installs nix so may be alright to be fixed in a later version of the action, though can revert back to unstable if that's preferred

This didn't work as I expected, it still installs nix so may be alright to be fixed in a later version of the action, though can revert back to unstable if that's preferred
silver commented 2024-10-01 08:22:19 +00:00
Owner
Copy link

Just after realising, I never signed off on any of the commits, sorry about that

That isnt an issue at all, not like ive trained anyone to set that up or to use it.

> Just after realising, I never signed off on any of the commits, sorry about that That isnt an issue at all, not like ive trained anyone to set that up or to use it.
eoghanconlon73 added 3 commits 2024-10-01 08:59:39 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 requested review from silver 2024-10-01 09:04:01 +00:00
eoghanconlon73 added 1 commit 2024-10-01 09:05:20 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 1 commit 2024-10-01 09:18:37 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 1 commit 2024-10-01 09:36:42 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 1 commit 2024-10-01 09:43:15 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 1 commit 2024-10-01 10:20:00 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 1 commit 2024-10-01 10:30:18 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 1 commit 2024-10-01 12:01:20 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 1 commit 2024-10-01 12:06:38 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
silver commented 2024-10-03 10:59:12 +00:00
Owner
Copy link

@eoghanconlon73 ye good with this now?

@eoghanconlon73 ye good with this now?
eoghanconlon73 added 1 commit 2024-10-04 11:28:14 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 1 commit 2024-10-04 13:27:28 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 1 commit 2024-10-04 13:54:56 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 1 commit 2024-10-04 16:18:37 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
eoghanconlon73 added 2 commits 2024-10-04 16:28:46 +00:00 
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
Signed-off-by: Eoghan Conlon <eoghanconlon73@skynet.ie>
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u main:eoghanconlon73-main
git checkout eoghanconlon73-main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff eoghanconlon73-main
git checkout eoghanconlon73-main
git rebase main
git checkout main
git merge --ff-only eoghanconlon73-main
git checkout eoghanconlon73-main
git rebase main
git checkout main
git merge --no-ff eoghanconlon73-main
git checkout main
git merge --squash eoghanconlon73-main
git checkout main
git merge --ff-only eoghanconlon73-main
git checkout main
git merge eoghanconlon73-main
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
silver
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Skynet/actions#2
No description provided.
Delete branch "eoghanconlon73/actions:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?