cordlesscoder cordlesscoder
  • Joined on 2025-09-11
cordlesscoder commented on pull request Skynet/discord-bot#43 2025-09-11 10:10:31 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos

Alright, that seems reasonable. Thanks for the explanation.

cordlesscoder commented on pull request Skynet/discord-bot#43 2025-09-11 09:57:55 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos

@silver wrote in Skynet/discord-bot#43 (comment):

@cordlesscoder wrote in #43 (comment):

What leads you to say I'm writing code I don't…

cordlesscoder pushed to main at cordlesscoder/discord-bot 2025-09-11 09:52:02 +00:00
0cd0d745e2 Ignore fix typos commit for git blame
cordlesscoder pushed to main at cordlesscoder/discord-bot 2025-09-11 09:35:04 +00:00
0c7a61fbf2 Use the longer format for some dependencies for compatibility with Taplo
59566deccf Roll back imports_granularity change
Compare 2 commits »
cordlesscoder commented on pull request Skynet/discord-bot#43 2025-09-11 09:32:24 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos

This is an env flag set on deployment. It will only fail if you provide an invalid value for configuration. So, the situation is: the discord bot has been started with improper configuration.…

cordlesscoder commented on pull request Skynet/discord-bot#43 2025-09-11 09:29:42 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos

The major bump happened 2 months ago and the TOML crate is ridiculously popular - I believe it's reasonable enough to assume that any regressions have been found and fixed. The image dependencies…

cordlesscoder commented on pull request Skynet/discord-bot#43 2025-09-11 09:16:25 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos

What leads you to say I'm writing code I don't understand? I made every change that has semantic significance with intent, and I can justify it just fine.

cordlesscoder commented on pull request Skynet/discord-bot#43 2025-09-11 09:12:39 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos

The original code instead ignores errors - that is not better.

cordlesscoder commented on pull request Skynet/discord-bot#43 2025-09-11 09:12:12 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos

The RwLock can't be required, as the only extra capability it adds is getting a mutable reference to the Database - something your code doesn't do once, and something sqlx's Pool intentionally avoids.

cordlesscoder commented on pull request Skynet/discord-bot#43 2025-09-11 09:08:44 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos

I didn't do this, my TOML formatter did(taplo). That's the dark side of enabling format on save :(

cordlesscoder commented on pull request Skynet/discord-bot#43 2025-09-11 09:07:52 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos

It isn't available in stable rustfmt, it's still a nightly feature

cordlesscoder commented on pull request Skynet/discord-bot#43 2025-09-11 08:43:54 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos

Please double check this replacement logic for FitTo

cordlesscoder created pull request Skynet/discord-bot#43 2025-09-11 08:18:22 +00:00
Update dependencies, remote unnecessary RwLock on database, fix typos
cordlesscoder pushed to main at cordlesscoder/discord-bot 2025-09-11 08:16:44 +00:00
4b4e5cb289 Fix typos
7b5626c279 Update dependencies, remove unnecessary RwLock on database
Compare 2 commits »
cordlesscoder created repository cordlesscoder/discord-bot 2025-09-11 08:15:14 +00:00