feat: add section on online banking #39

Merged
silver merged 12 commits from #38_Add-Online-banking into main 2026-03-01 18:25:27 +00:00
Owner

In case we get hit by a bus

In case we get hit by a bus
Contributor

"It does not requite the previous Admins to be present" should probably be require

Imo submit would look better as point 9 rather than a subpoint of point 8

"It does not **requite** the previous Admins to be present" should probably be require Imo submit would look better as point 9 rather than a subpoint of point 8
First-time contributor
  • Clarify, What the Mandate is so having a webpage/Asterisk included at the bottom explaining it
  • Clarify, What and Where to find the Bank Statement
  • Say Admin 1 & 2 should be in handover documents
  • In point 7 change to New Admin
- Clarify, What the Mandate is so having a webpage/Asterisk included at the bottom explaining it - Clarify, What and **Where to find** the Bank Statement - Say Admin 1 & 2 should be in handover documents - In point 7 change to New Admin
Author
Owner

@kaiden wrote in #39 (comment):

  • Clarify, What the Mandate is so having a webpage/Asterisk included at the bottom explaining it

That will be in a separate page entirely

  • Clarify, What and Where to find the Bank Statement

Good point

  • Say Admin 1 & 2 should be in handover documents

Can ye clarify this?

  • In point 7 change to New Admin

Thanks

@kaiden wrote in https://forgejo.skynet.ie/Skynet/wiki/pulls/39#issuecomment-2968: > * Clarify, What the Mandate is so having a webpage/Asterisk included at the bottom explaining it That will be in a separate page entirely > * Clarify, What and **Where to find** the Bank Statement Good point > * Say Admin 1 & 2 should be in handover documents Can ye clarify this? > * In point 7 change to New Admin Thanks
First-time contributor

For the Admin bit it's just for point 6 saying that they should be in the handover documents first instead of going to the help desk though I get just saying the help desk as it will definitely resolve the issue

For the Admin bit it's just for point 6 saying that they should be in the handover documents first instead of going to the help desk though I get just saying the help desk as it will definitely resolve the issue
Author
Owner

Same as before a rough example of what it will look like is available here:
https://forgejo.skynet.ie/Skynet/wiki/src/branch/%2338_Add-Online-banking/src/committee/banking/online.md

With it looking like this on the wiki Screenshot 2026-02-18 at 02-05-50 Online Banking - Update Admin - Skynet Wiki

Same as before a rough example of what it will look like is available here: https://forgejo.skynet.ie/Skynet/wiki/src/branch/%2338_Add-Online-banking/src/committee/banking/online.md With it looking like this on the wiki ![Screenshot 2026-02-18 at 02-05-50 Online Banking - Update Admin - Skynet Wiki](/attachments/602d716c-f2a5-47db-ae97-0f4cb1be91f5)
amymucko approved these changes 2026-02-20 16:40:06 +00:00
amymucko left a comment
First-time contributor

From what i can see it looks good but a bit hard to glean its straight-forwardness in terms of instructions as i donn't know how the system works

From what i can see it looks good but a bit hard to glean its straight-forwardness in terms of instructions as i donn't know how the system works
First-time contributor
-  * During the phonecall you might be able to obtain this.
+  * During the phone call, you might be able to obtain this.

- * This step involves making phonecalls, being polite helps immensely here.
+ * This step involves making phone calls; being polite helps immensely here.

Beyond these two LGTM

```diff - * During the phonecall you might be able to obtain this. + * During the phone call, you might be able to obtain this. - * This step involves making phonecalls, being polite helps immensely here. + * This step involves making phone calls; being polite helps immensely here. Beyond these two LGTM ```
First-time contributor

NIT at Line 58. Saying Select the option which makes sense is coming off as rude and dismissive, consider rewording.

NIT at Line 102, perhaps consider rewording to Complete the steps in Applying for the Change.

At line 148 in online.md is the width="500" supposed to be visible? This is happening for the rest of the images in the file.

Line 152, elaborate on the (NB: not 100% sure of this). As in does it not work or what issues could possibly arise with the temp password?

Possible typo at line 155, correct Treasuerer to Treasurer

NIT at Line 58. Saying `Select the option which makes sense` is coming off as rude and dismissive, consider rewording. NIT at Line 102, perhaps consider rewording to `Complete the steps in Applying for the Change.` At line 148 in `online.md` is the `width="500"` supposed to be visible? This is happening for the rest of the images in the file. Line 152, elaborate on the `(NB: not 100% sure of this)`. As in does it not work or what issues could possibly arise with the temp password? Possible typo at line 155, correct `Treasuerer` to `Treasurer`
Author
Owner

@skyapples wrote in #39 (comment):

NIT at Line 58. Saying Select the option which makes sense is coming off as rude and dismissive, consider rewording.

How would ye phrase it then, since there are 4 different options, not all are useful for the person doign it at that time.

NIT at Line 102, perhaps consider rewording to Complete the steps in Applying for the Change.

That is a link that goes back to teh requirements for teh Apply for the Change category.

At line 148 in online.md is the width="500" supposed to be visible? This is happening for the rest of the images in the file.

This is not visible for the user, only in teh markdown itself (its a way of specificing teh max size for teh image (makes them nice and even on teh page)

Line 152, elaborate on the (NB: not 100% sure of this). As in does it not work or what issues could possibly arise with the temp password?

This time round we were only setting up a single admin, last time we were changing both at once was two eyars ago and I literally cannot remember.
Next time two admins are being changed this can be updated/improved.

Possible typo at line 155, correct Treasuerer to Treasurer

Didnt notice this, thank ye!

@skyapples wrote in https://forgejo.skynet.ie/Skynet/wiki/pulls/39#issuecomment-2985: > NIT at Line 58. Saying `Select the option which makes sense` is coming off as rude and dismissive, consider rewording. How would ye phrase it then, since there are 4 different options, not all are useful for the person doign it at that time. > NIT at Line 102, perhaps consider rewording to `Complete the steps in Applying for the Change.` That is a link that goes back to teh requirements for teh ``Apply for the Change`` category. > At line 148 in `online.md` is the `width="500"` supposed to be visible? This is happening for the rest of the images in the file. This is not visible for the user, only in teh markdown itself (its a way of specificing teh max size for teh image (makes them nice and even on teh page) > Line 152, elaborate on the `(NB: not 100% sure of this)`. As in does it not work or what issues could possibly arise with the temp password? This time round we were only setting up a single admin, last time we were changing both at once was two eyars ago and I literally cannot remember. Next time two admins are being changed this can be updated/improved. > Possible typo at line 155, correct `Treasuerer` to `Treasurer` Didnt notice this, thank ye!
First-time contributor

How would ye phrase it then, since there are 4 different options, not all are useful for the person doign it at that time.

Something like Pick the options that sound like what you're looking for. If you arrived at the wrong place ask to be redirected to the correct service if possible. Otherwise try again.,

That is a link that goes back to teh requirements for teh Apply for the Change category.

Sorry, I meant that the wording felt a bit off, the rewording was mostly to specify to actually complete the category before moving on in case they skip ahead too much in the document.

This is not visible for the user, only in teh markdown itself (its a way of specificing teh max size for teh image (makes them nice and even on teh page)

Sorry, I meant this showing up in the rendered document
image

This time round we were only setting up a single admin, last time we were changing both at once was two eyars ago and I literally cannot remember.

Yeah if that's the case then fair enough.

Otherwise LGTM.

> How would ye phrase it then, since there are 4 different options, not all are useful for the person doign it at that time. Something like `Pick the options that sound like what you're looking for. If you arrived at the wrong place ask to be redirected to the correct service if possible. Otherwise try again.`, > That is a link that goes back to teh requirements for teh Apply for the Change category. Sorry, I meant that the wording felt a bit off, the rewording was mostly to specify to actually complete the category before moving on in case they skip ahead too much in the document. > This is not visible for the user, only in teh markdown itself (its a way of specificing teh max size for teh image (makes them nice and even on teh page) Sorry, I meant this showing up in the rendered document ![image](/attachments/0b070132-8345-4421-b135-98ed4567aa40) > This time round we were only setting up a single admin, last time we were changing both at once was two eyars ago and I literally cannot remember. Yeah if that's the case then fair enough. Otherwise LGTM.
Author
Owner

Something like Pick the options that sound like what you're looking for. If you arrived at the wrong place ask to be redirected to the correct service if possible. Otherwise try again.,

Its a dropdown menu, there is no redirection, couldnt think of any simpler way to state this

Sorry, I meant that the wording felt a bit off, the rewording was mostly to specify to actually complete the category before moving on in case they skip ahead too much in the document.

They could try to do things out of order, but they wont get far with that.
This is basically the happy path.

The {width="500"} only shows up on teh web view of teh markdown document.
Take a look at #39 (comment) to see the actual rendered document

> Something like Pick the options that sound like what you're looking for. If you arrived at the wrong place ask to be redirected to the correct service if possible. Otherwise try again., Its a dropdown menu, there is no redirection, couldnt think of any simpler way to state this > Sorry, I meant that the wording felt a bit off, the rewording was mostly to specify to actually complete the category before moving on in case they skip ahead too much in the document. They could try to do things out of order, but they wont get far with that. This is basically the happy path. The ``{width="500"}`` only shows up on teh web view of teh markdown document. Take a look at https://forgejo.skynet.ie/Skynet/wiki/pulls/39#issuecomment-2973 to see the actual rendered document
First-time contributor

Fair enough, in that case LGTM.

Fair enough, in that case LGTM.
silver merged commit 30c62219f7 into main 2026-03-01 18:25:27 +00:00
silver deleted branch #38_Add-Online-banking 2026-03-01 18:25:27 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Skynet/wiki!39
No description provided.