Skynet/website_2023
6
0
Fork 1
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

fix accessibility + remove 2 dead links #2

Merged
silver merged 1 commit from anton-exe/website_2023:main into main 2025-09-18 11:43:08 +00:00
Conversation 1 Commits 1 Files changed 2 +41 -33
anton-exe commented 2025-09-18 11:16:34 +00:00
Contributor
Copy link

exact list of changes is:

  • make header a semi-transparent black on PC, making it visible when scrolling over a white background
  • remove h1 tag from logo, as screen readers can jump between headings and may get confused by the seemingly empty heading
  • add h1 tag to the title, inverse reason of above
  • change some CSS colours to fix contrast issues (primarily in the notice)
    • side note: that notice is over a year old, maybe remove it?
  • reword some links to be more descriptive when tabbing through
  • remove 2 dead links (games.skynet.ie and skynet.ie/forum)
  • add alt text to every image (except those marked empty as i assume that was intentional)
  • merge the contact links into on tag each to make tabbing easier
exact list of changes is: - make header a semi-transparent black on PC, making it visible when scrolling over a white background - remove h1 tag from logo, as screen readers can jump between headings and may get confused by the seemingly empty heading - add h1 tag to the title, inverse reason of above - change some CSS colours to fix contrast issues (primarily in the notice) - side note: that notice is over a year old, maybe remove it? - reword some links to be more descriptive when tabbing through - remove 2 dead links (games.skynet.ie and skynet.ie/forum) - add alt text to every image (except those marked empty as i assume that was intentional) - merge the contact links into on <a> tag each to make tabbing easier
silver commented 2025-09-18 11:43:02 +00:00
Owner
Copy link

Looks good to me!

Looks good to me!
silver merged commit afd5571791 into main 2025-09-18 11:43:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
Trainee - Good First Issue

Something that is good for first issue

No labels
Trainee - Good First Issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Skynet/website_2023#2
No description provided.
Delete branch "anton-exe/website_2023:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?