php-cs fixes

app/Http/Controllers/Api/Application/Nodes/NodeController.php

@@ -65,7 +65,7 @@ class NodeController extends ApplicationApiController
         $perPage = $request->query('per_page', 10);
         if ($perPage < 1) {
             $perPage = 10;
-        } else if ($perPage > 100) {
+        } elseif ($perPage > 100) {
             throw new BadRequestHttpException('"per_page" query parameter must be below 100.');
         }
 

app/Http/Controllers/Api/Application/Roles/RoleController.php

@@ -25,9 +25,6 @@ class RoleController extends ApplicationApiController
     /**
      * Returns an array of all roles.
      *
-     * @param \Pterodactyl\Http\Requests\Api\Application\Roles\GetRolesRequest $request
-     *
-     * @return array
      * @throws \Illuminate\Contracts\Container\BindingResolutionException
      */
     public function index(GetRolesRequest $request): array
@@ -40,10 +37,6 @@ class RoleController extends ApplicationApiController
     /**
      * Returns a single role.
      *
-     * @param \Pterodactyl\Http\Requests\Api\Application\Roles\GetRoleRequest $request
-     * @param \Pterodactyl\Models\AdminRole $role
-     *
-     * @return array
      * @throws \Illuminate\Contracts\Container\BindingResolutionException
      */
     public function view(GetRoleRequest $request, AdminRole $role): array
@@ -56,14 +49,14 @@ class RoleController extends ApplicationApiController
     /**
      * Creates a new role.
      *
-     * @param \Pterodactyl\Http\Requests\Api\Application\Roles\StoreRoleRequest $request
-     *
-     * @return \Illuminate\Http\JsonResponse
      * @throws \Illuminate\Contracts\Container\BindingResolutionException
      */
     public function store(StoreRoleRequest $request): JsonResponse
     {
-        $role = AdminRole::query()->create($request->validated());
+        $data = array_merge($request->validated(), [
+            'sort_id' => 99,
+        ]);
+        $role = AdminRole::query()->create($data);
 
         return $this->fractal->item($role)
             ->transformWith($this->getTransformer(AdminRoleTransformer::class))
@@ -73,10 +66,6 @@ class RoleController extends ApplicationApiController
     /**
      * Updates a role.
      *
-     * @param \Pterodactyl\Http\Requests\Api\Application\Roles\UpdateRoleRequest $request
-     * @param \Pterodactyl\Models\AdminRole $role
-     *
-     * @return array
      * @throws \Illuminate\Contracts\Container\BindingResolutionException
      */
     public function update(UpdateRoleRequest $request, AdminRole $role): array
@@ -91,10 +80,6 @@ class RoleController extends ApplicationApiController
     /**
      * Deletes a role.
      *
-     * @param \Pterodactyl\Http\Requests\Api\Application\Roles\DeleteRoleRequest $request
-     * @param \Pterodactyl\Models\AdminRole $role
-     *
-     * @return \Illuminate\Http\JsonResponse
      * @throws \Exception
      */
     public function delete(DeleteRoleRequest $request, AdminRole $role): JsonResponse

app/Http/Controllers/Api/Application/Servers/ServerController.php

@@ -18,15 +18,8 @@ use Pterodactyl\Http\Controllers\Api\Application\ApplicationApiController;
 
 class ServerController extends ApplicationApiController
 {
-    /**
-     * @var \Pterodactyl\Services\Servers\ServerCreationService
-     */
-    private $creationService;
-
-    /**
-     * @var \Pterodactyl\Services\Servers\ServerDeletionService
-     */
-    private $deletionService;
+    private ServerCreationService $creationService;
+    private ServerDeletionService $deletionService;
 
     /**
      * ServerController constructor.
@@ -43,13 +36,15 @@ class ServerController extends ApplicationApiController
 
     /**
      * Return all of the servers that currently exist on the Panel.
+     *
+     * @throws \Illuminate\Contracts\Container\BindingResolutionException
      */
     public function index(GetServersRequest $request): array
     {
         $perPage = $request->query('per_page', 10);
         if ($perPage < 1) {
             $perPage = 10;
-        } else if ($perPage > 100) {
+        } elseif ($perPage > 100) {
             throw new BadRequestHttpException('"per_page" query parameter must be below 100.');
         }
 
@@ -84,6 +79,8 @@ class ServerController extends ApplicationApiController
 
     /**
      * Show a single server transformed for the application API.
+     *
+     * @throws \Illuminate\Contracts\Container\BindingResolutionException
      */
     public function view(GetServerRequest $request, Server $server): array
     {
@@ -93,7 +90,15 @@ class ServerController extends ApplicationApiController
     }
 
     /**
+     * Deletes a server.
+     *
+     * @param \Pterodactyl\Http\Requests\Api\Application\Servers\ServerWriteRequest $request
+     * @param \Pterodactyl\Models\Server $server
+     * @param string $force
+     *
+     * @return \Illuminate\Http\Response
      * @throws \Pterodactyl\Exceptions\DisplayException
+     * @throws \Throwable
      */
     public function delete(ServerWriteRequest $request, Server $server, string $force = ''): Response
     {

app/Http/Controllers/Api/Application/Users/UserController.php

@@ -72,7 +72,7 @@ class UserController extends ApplicationApiController
         $perPage = $request->query('per_page', 10);
         if ($perPage < 1) {
             $perPage = 10;
-        } else if ($perPage > 100) {
+        } elseif ($perPage > 100) {
             throw new BadRequestHttpException('"per_page" query parameter must be below 100.');
         }