Try to handle terminal fit a bit better; closes #3121

I'm not sure how to fix this actually, but based on the light reading I did theoretically this should at least prevent it from trying to fit something that doesn't even exist?
This commit is contained in:
Dane Everitt 2021-03-03 19:44:06 -08:00
parent bc87a9cf7d
commit 68bc81f2f1
No known key found for this signature in database
GPG key ID: EEA66103B3D71F53

View file

@ -1,4 +1,4 @@
import React, { useEffect, useMemo, useRef, useState } from 'react';
import React, { useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';
import { ITerminalOptions, Terminal } from 'xterm';
import { FitAddon } from 'xterm-addon-fit';
import { SearchAddon } from 'xterm-addon-search';
@ -135,11 +135,12 @@ export default () => {
useEffect(() => {
if (connected && ref.current && !terminal.element) {
terminal.open(ref.current);
terminal.loadAddon(fitAddon);
terminal.loadAddon(searchAddon);
terminal.loadAddon(searchBar);
terminal.loadAddon(webLinksAddon);
terminal.open(ref.current);
fitAddon.fit();
// Add support for capturing keys
@ -159,11 +160,11 @@ export default () => {
}
}, [ terminal, connected ]);
const fit = debounce(() => {
useEventListener('resize', debounce(() => {
if (terminal.element) {
fitAddon.fit();
}, 100);
useEventListener('resize', () => fit());
}
}, 100));
useEffect(() => {
const listeners: Record<string, (s: string) => void> = {