Perform a bit of code cleanup
This commit is contained in:
parent
be88e4e893
commit
4d3362b24f
6 changed files with 6 additions and 82 deletions
|
@ -86,6 +86,8 @@ class LoginController extends AbstractLoginController
|
||||||
|
|
||||||
$this->auth->guard()->login($user, true);
|
$this->auth->guard()->login($user, true);
|
||||||
|
|
||||||
|
$request->session()->regenerate();
|
||||||
|
|
||||||
return $this->sendLoginResponse($user, $request);
|
return $this->sendLoginResponse($user, $request);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -11,7 +11,6 @@ use Pterodactyl\Http\Middleware\EncryptCookies;
|
||||||
use Pterodactyl\Http\Middleware\Api\IsValidJson;
|
use Pterodactyl\Http\Middleware\Api\IsValidJson;
|
||||||
use Pterodactyl\Http\Middleware\VerifyCsrfToken;
|
use Pterodactyl\Http\Middleware\VerifyCsrfToken;
|
||||||
use Pterodactyl\Http\Middleware\VerifyReCaptcha;
|
use Pterodactyl\Http\Middleware\VerifyReCaptcha;
|
||||||
use Pterodactyl\Http\Middleware\AdminAuthenticate;
|
|
||||||
use Illuminate\Routing\Middleware\ThrottleRequests;
|
use Illuminate\Routing\Middleware\ThrottleRequests;
|
||||||
use Pterodactyl\Http\Middleware\LanguageMiddleware;
|
use Pterodactyl\Http\Middleware\LanguageMiddleware;
|
||||||
use Illuminate\Foundation\Http\Kernel as HttpKernel;
|
use Illuminate\Foundation\Http\Kernel as HttpKernel;
|
||||||
|
@ -65,9 +64,9 @@ class Kernel extends HttpKernel
|
||||||
RequireTwoFactorAuthentication::class,
|
RequireTwoFactorAuthentication::class,
|
||||||
],
|
],
|
||||||
'api' => [
|
'api' => [
|
||||||
IsValidJson::class,
|
|
||||||
EnsureStatefulRequests::class,
|
EnsureStatefulRequests::class,
|
||||||
'auth:sanctum',
|
'auth:sanctum',
|
||||||
|
IsValidJson::class,
|
||||||
RequireTwoFactorAuthentication::class,
|
RequireTwoFactorAuthentication::class,
|
||||||
AuthenticateIPAccess::class,
|
AuthenticateIPAccess::class,
|
||||||
],
|
],
|
||||||
|
@ -93,7 +92,6 @@ class Kernel extends HttpKernel
|
||||||
'auth' => Authenticate::class,
|
'auth' => Authenticate::class,
|
||||||
'auth.basic' => AuthenticateWithBasicAuth::class,
|
'auth.basic' => AuthenticateWithBasicAuth::class,
|
||||||
'guest' => RedirectIfAuthenticated::class,
|
'guest' => RedirectIfAuthenticated::class,
|
||||||
'admin' => AdminAuthenticate::class,
|
|
||||||
'csrf' => VerifyCsrfToken::class,
|
'csrf' => VerifyCsrfToken::class,
|
||||||
'throttle' => ThrottleRequests::class,
|
'throttle' => ThrottleRequests::class,
|
||||||
'can' => Authorize::class,
|
'can' => Authorize::class,
|
||||||
|
|
|
@ -1,26 +0,0 @@
|
||||||
<?php
|
|
||||||
|
|
||||||
namespace Pterodactyl\Http\Middleware;
|
|
||||||
|
|
||||||
use Closure;
|
|
||||||
use Illuminate\Http\Request;
|
|
||||||
use Illuminate\Auth\AuthenticationException;
|
|
||||||
|
|
||||||
class Authenticate
|
|
||||||
{
|
|
||||||
/**
|
|
||||||
* Handle an incoming request.
|
|
||||||
*
|
|
||||||
* @return mixed
|
|
||||||
*
|
|
||||||
* @throws \Illuminate\Auth\AuthenticationException
|
|
||||||
*/
|
|
||||||
public function handle(Request $request, Closure $next)
|
|
||||||
{
|
|
||||||
if (!$request->user()) {
|
|
||||||
throw new AuthenticationException();
|
|
||||||
}
|
|
||||||
|
|
||||||
return $next($request);
|
|
||||||
}
|
|
||||||
}
|
|
|
@ -8,6 +8,7 @@ use Illuminate\Support\Facades\Route;
|
||||||
use Illuminate\Cache\RateLimiting\Limit;
|
use Illuminate\Cache\RateLimiting\Limit;
|
||||||
use Illuminate\Support\Facades\RateLimiter;
|
use Illuminate\Support\Facades\RateLimiter;
|
||||||
use Pterodactyl\Http\Middleware\TrimStrings;
|
use Pterodactyl\Http\Middleware\TrimStrings;
|
||||||
|
use Pterodactyl\Http\Middleware\AdminAuthenticate;
|
||||||
use Illuminate\Foundation\Support\Providers\RouteServiceProvider as ServiceProvider;
|
use Illuminate\Foundation\Support\Providers\RouteServiceProvider as ServiceProvider;
|
||||||
|
|
||||||
class RouteServiceProvider extends ServiceProvider
|
class RouteServiceProvider extends ServiceProvider
|
||||||
|
@ -33,10 +34,10 @@ class RouteServiceProvider extends ServiceProvider
|
||||||
Route::model('database', Database::class);
|
Route::model('database', Database::class);
|
||||||
|
|
||||||
$this->routes(function () {
|
$this->routes(function () {
|
||||||
Route::middleware(['web', 'csrf'])->group(function () {
|
Route::middleware('web')->group(function () {
|
||||||
Route::middleware('auth')->group(base_path('routes/base.php'));
|
Route::middleware('auth')->group(base_path('routes/base.php'));
|
||||||
Route::middleware('guest')->prefix('/auth')->group(base_path('routes/auth.php'));
|
Route::middleware('guest')->prefix('/auth')->group(base_path('routes/auth.php'));
|
||||||
Route::middleware(['auth', 'admin'])->prefix('/admin')->group(base_path('routes/admin.php'));
|
Route::middleware(['auth', AdminAuthenticate::class])->prefix('/admin')->group(base_path('routes/admin.php'));
|
||||||
});
|
});
|
||||||
|
|
||||||
Route::middleware('api')->group(function () {
|
Route::middleware('api')->group(function () {
|
||||||
|
|
|
@ -11,18 +11,6 @@ const http: AxiosInstance = axios.create({
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
http.interceptors.request.use(req => {
|
|
||||||
const cookies = document.cookie.split(';').reduce((obj, val) => {
|
|
||||||
const [ key, value ] = val.trim().split('=').map(decodeURIComponent);
|
|
||||||
|
|
||||||
return { ...obj, [key]: value };
|
|
||||||
}, {} as Record<string, string>);
|
|
||||||
|
|
||||||
req.headers['X-XSRF-TOKEN'] = cookies['XSRF-TOKEN'] || 'nil';
|
|
||||||
|
|
||||||
return req;
|
|
||||||
});
|
|
||||||
|
|
||||||
http.interceptors.request.use(req => {
|
http.interceptors.request.use(req => {
|
||||||
if (!req.url?.endsWith('/resources')) {
|
if (!req.url?.endsWith('/resources')) {
|
||||||
store.getActions().progress.startContinuous();
|
store.getActions().progress.startContinuous();
|
||||||
|
|
|
@ -1,39 +0,0 @@
|
||||||
<?php
|
|
||||||
|
|
||||||
namespace Pterodactyl\Tests\Unit\Http\Middleware;
|
|
||||||
|
|
||||||
use Illuminate\Auth\AuthenticationException;
|
|
||||||
use Pterodactyl\Http\Middleware\Authenticate;
|
|
||||||
|
|
||||||
class AuthenticateTest extends MiddlewareTestCase
|
|
||||||
{
|
|
||||||
/**
|
|
||||||
* Test that a logged in user validates correctly.
|
|
||||||
*/
|
|
||||||
public function testLoggedInUser()
|
|
||||||
{
|
|
||||||
$this->request->shouldReceive('user')->withNoArgs()->once()->andReturn(true);
|
|
||||||
|
|
||||||
$this->getMiddleware()->handle($this->request, $this->getClosureAssertions());
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Test that a logged out user results in an exception.
|
|
||||||
*/
|
|
||||||
public function testLoggedOutUser()
|
|
||||||
{
|
|
||||||
$this->expectException(AuthenticationException::class);
|
|
||||||
|
|
||||||
$this->request->shouldReceive('user')->withNoArgs()->once()->andReturnNull();
|
|
||||||
|
|
||||||
$this->getMiddleware()->handle($this->request, $this->getClosureAssertions());
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Return an instance of the middleware using mocked dependencies.
|
|
||||||
*/
|
|
||||||
private function getMiddleware(): Authenticate
|
|
||||||
{
|
|
||||||
return new Authenticate();
|
|
||||||
}
|
|
||||||
}
|
|
Loading…
Reference in a new issue