Skynet/misc_pterodactyl-panel
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add test coverage for change to endpoint

Browse source
This commit is contained in:
Dane Everitt 2020-10-15 21:32:49 -07:00
parent a4abb2543b
commit 40d44598da
No known key found for this signature in database
GPG key ID: EEA66103B3D71F53
1 changed files with 44 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
tests/Integration/Api/Client/ClientControllerTest.php
View file

@ -154,10 +154,42 @@ class ClientControllerTest extends ClientApiIntegrationTestCase
} }
/** /**
* Test that no servers get returned if the user requests all admin level servers by using * Test that all servers a user can access as an admin are returned if using ?filter=admin-all.
* ?type=admin in the request.
*/ */
public function testNoServersAreReturnedIfAdminFilterIsPassedByRegularUser() public function testAllServersAreReturnedToAdmin()
{
/** @var \Pterodactyl\Models\User[] $users */
$users = factory(User::class)->times(4)->create();
$users[0]->update(['root_admin' => true]);
$servers = [
$this->createServerModel(['user_id' => $users[0]->id]),
$this->createServerModel(['user_id' => $users[1]->id]),
$this->createServerModel(['user_id' => $users[2]->id]),
$this->createServerModel(['user_id' => $users[3]->id]),
];
Subuser::query()->create([
'user_id' => $users[0]->id,
'server_id' => $servers[1]->id,
'permissions' => [Permission::ACTION_WEBSOCKET_CONNECT],
]);
// All servers should be returned.
$response = $this->actingAs($users[0])->getJson('/api/client?type=admin-all');
$response->assertOk();
$response->assertJsonCount(4, 'data');
}
/**
* Test that no servers get returned if the user requests all admin level servers by using
* ?type=admin or ?type=admin-all in the request.
*
* @param string $type
* @dataProvider filterTypeDataProvider
*/
public function testNoServersAreReturnedIfAdminFilterIsPassedByRegularUser($type)
{ {
/** @var \Pterodactyl\Models\User[] $users */ /** @var \Pterodactyl\Models\User[] $users */
$users = factory(User::class)->times(3)->create(); $users = factory(User::class)->times(3)->create();
@ -166,9 +198,17 @@ class ClientControllerTest extends ClientApiIntegrationTestCase
$this->createServerModel(['user_id' => $users[1]->id]); $this->createServerModel(['user_id' => $users[1]->id]);
$this->createServerModel(['user_id' => $users[2]->id]); $this->createServerModel(['user_id' => $users[2]->id]);
$response = $this->actingAs($users[0])->getJson('/api/client?type=admin'); $response = $this->actingAs($users[0])->getJson('/api/client?type=' . $type);
$response->assertOk(); $response->assertOk();
$response->assertJsonCount(0, 'data'); $response->assertJsonCount(0, 'data');
} }
/**
* @return array
*/
public function filterTypeDataProvider()
{
return [['admin'], ['admin-all']];
}
} }