Skynet/misc_pterodactyl-panel
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix component stack depth crashes due to looping setState

Browse source
This commit is contained in:
Dane Everitt 2021-05-29 10:58:24 -07:00
parent c5b6d0bf45
commit 2fd16f441d
No known key found for this signature in database
GPG key ID: EEA66103B3D71F53
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
resources/scripts/hoc/asModal.tsx
View file

@ -1,6 +1,7 @@
import React from 'react'; import React from 'react';
import PortaledModal, { ModalProps } from '@/components/elements/Modal'; import PortaledModal, { ModalProps } from '@/components/elements/Modal';
import ModalContext, { ModalContextValues } from '@/context/ModalContext'; import ModalContext, { ModalContextValues } from '@/context/ModalContext';
import isEqual from 'react-fast-compare';
export interface AsModalProps { export interface AsModalProps {
visible: boolean; visible: boolean;
@ -47,13 +48,13 @@ function asModal<P extends {}> (modalProps?: SettableModalProps | ((props: P) =>
/** /**
* @this {React.PureComponent<P & AsModalProps, State>} * @this {React.PureComponent<P & AsModalProps, State>}
*/ */
componentDidUpdate (prevProps: Readonly<P & AsModalProps>) { componentDidUpdate (prevProps: Readonly<P & AsModalProps>, prevState: Readonly<State>) {
if (prevProps.visible && !this.props.visible) { if (prevProps.visible && !this.props.visible) {
this.setState({ visible: false, showSpinnerOverlay: false }); this.setState({ visible: false, showSpinnerOverlay: false });
} else if (!prevProps.visible && this.props.visible) { } else if (!prevProps.visible && this.props.visible) {
this.setState({ render: true, visible: true }); this.setState({ render: true, visible: true });
} }
if (!this.state.render) { if (!this.state.render && !isEqual(prevState.propOverrides, this.state.propOverrides)) {
this.setState({ propOverrides: {} }); this.setState({ propOverrides: {} });
} }
} }