Skynet/misc_pterodactyl-panel
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Handle 404 errors in API bindings correctly to avoid explosing that a resource exists before validating a key

Browse source
This commit is contained in:
Dane Everitt 2018-02-27 21:04:04 -06:00
parent a765e0dbb6
commit 23e07689a7
No known key found for this signature in database
GPG key ID: EEA66103B3D71F53
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -6,6 +6,7 @@ This project follows [Semantic Versioning](http://semver.org) guidelines.
## v0.7.4 (Derelict Dermodactylus) ## v0.7.4 (Derelict Dermodactylus)
### Fixed ### Fixed
* Fixes a bug when reinstalling a server that would not mark the server as installing, resulting in some UI issues. * Fixes a bug when reinstalling a server that would not mark the server as installing, resulting in some UI issues.
* Handle 404 errors from missing models in the application API bindings correctly.
## v0.7.3 (Derelict Dermodactylus) ## v0.7.3 (Derelict Dermodactylus)
### Fixed ### Fixed

4
app/Http/Middleware/Api/ApiSubstituteBindings.php
View file

@ -45,7 +45,9 @@ class ApiSubstituteBindings extends SubstituteBindings
$route = $request->route(); $route = $request->route();
foreach (self::$mappings as $key => $model) { foreach (self::$mappings as $key => $model) {
$this->router->model($key, $model); $this->router->model($key, $model, function () use ($request) {
$request->attributes->set('is_missing_model', true);
});
} }
$this->router->substituteBindings($route); $this->router->substituteBindings($route);