Skynet/misc_pterodactyl-panel
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update tests

Browse source
This commit is contained in:
Lance Pioch 2022-10-24 00:25:17 -04:00
parent 483c081d7f
commit 203f88f09e
1 changed files with 17 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
tests/Integration/Services/Databases/DatabaseManagementServiceTest.php
View file

@ -2,14 +2,11 @@
namespace Pterodactyl\Tests\Integration\Services\Databases; namespace Pterodactyl\Tests\Integration\Services\Databases;
use Mockery;
use Mockery\MockInterface;
use BadMethodCallException; use BadMethodCallException;
use InvalidArgumentException; use InvalidArgumentException;
use Pterodactyl\Models\Database; use Pterodactyl\Models\Database;
use Pterodactyl\Models\DatabaseHost; use Pterodactyl\Models\DatabaseHost;
use Pterodactyl\Tests\Integration\IntegrationTestCase; use Pterodactyl\Tests\Integration\IntegrationTestCase;
use Pterodactyl\Repositories\Eloquent\DatabaseRepository;
use Pterodactyl\Services\Databases\DatabaseManagementService; use Pterodactyl\Services\Databases\DatabaseManagementService;
use Pterodactyl\Exceptions\Repository\DuplicateDatabaseNameException; use Pterodactyl\Exceptions\Repository\DuplicateDatabaseNameException;
use Pterodactyl\Exceptions\Service\Database\TooManyDatabasesException; use Pterodactyl\Exceptions\Service\Database\TooManyDatabasesException;
@ -17,8 +14,6 @@ use Pterodactyl\Exceptions\Service\Database\DatabaseClientFeatureNotEnabledExcep
class DatabaseManagementServiceTest extends IntegrationTestCase class DatabaseManagementServiceTest extends IntegrationTestCase
{ {
private MockInterface $repository;
/** /**
* Setup tests. * Setup tests.
*/ */
@ -27,8 +22,6 @@ class DatabaseManagementServiceTest extends IntegrationTestCase
parent::setUp(); parent::setUp();
config()->set('pterodactyl.client_features.databases.enabled', true); config()->set('pterodactyl.client_features.databases.enabled', true);
$this->repository = $this->mock(DatabaseRepository::class);
} }
/** /**
@ -91,7 +84,7 @@ class DatabaseManagementServiceTest extends IntegrationTestCase
public function testCreatingDatabaseWithIdenticalNameTriggersAnException() public function testCreatingDatabaseWithIdenticalNameTriggersAnException()
{ {
$server = $this->createServerModel(); $server = $this->createServerModel();
$name = DatabaseManagementService::generateUniqueDatabaseName('soemthing', $server->id); $name = DatabaseManagementService::generateUniqueDatabaseName('something', $server->id);
$host = DatabaseHost::factory()->create(['node_id' => $server->node_id]); $host = DatabaseHost::factory()->create(['node_id' => $server->node_id]);
$host2 = DatabaseHost::factory()->create(['node_id' => $server->node_id]); $host2 = DatabaseHost::factory()->create(['node_id' => $server->node_id]);
@ -119,43 +112,19 @@ class DatabaseManagementServiceTest extends IntegrationTestCase
*/ */
public function testServerDatabaseCanBeCreated() public function testServerDatabaseCanBeCreated()
{ {
$this->markTestSkipped();
/* TODO: The exception is because the transaction is closed
because the database create closes it early */
$server = $this->createServerModel(); $server = $this->createServerModel();
$name = DatabaseManagementService::generateUniqueDatabaseName('soemthing', $server->id); $name = DatabaseManagementService::generateUniqueDatabaseName('something', $server->id);
$host = DatabaseHost::factory()->create(['node_id' => $server->node_id]); $host = DatabaseHost::factory()->create(['node_id' => $server->node_id]);
$this->repository->expects('createDatabase')->with($name);
$username = null; $username = null;
$secondUsername = null; $secondUsername = null;
$password = null; $password = null;
// The value setting inside the closures if to avoid throwing an exception during the
// assertions that would get caught by the functions catcher and thus lead to the exception
// being swallowed incorrectly.
$this->repository->expects('createUser')->with(
Mockery::on(function ($value) use (&$username) {
$username = $value;
return true;
}),
'%',
Mockery::on(function ($value) use (&$password) {
$password = $value;
return true;
}),
null
);
$this->repository->expects('assignUserToDatabase')->with($name, Mockery::on(function ($value) use (&$secondUsername) {
$secondUsername = $value;
return true;
}), '%');
$this->repository->expects('flush')->withNoArgs();
$response = $this->getService()->create($server, [ $response = $this->getService()->create($server, [
'remote' => '%', 'remote' => '%',
'database' => $name, 'database' => $name,
@ -177,18 +146,23 @@ class DatabaseManagementServiceTest extends IntegrationTestCase
*/ */
public function testExceptionEncounteredWhileCreatingDatabaseAttemptsToCleanup() public function testExceptionEncounteredWhileCreatingDatabaseAttemptsToCleanup()
{ {
$this->markTestSkipped();
/* TODO: I think this is useful logic to be tested,
but this is a very hacky way of going about it.
The exception is because the transaction is closed
because the database create closes it early */
$server = $this->createServerModel(); $server = $this->createServerModel();
$name = DatabaseManagementService::generateUniqueDatabaseName('soemthing', $server->id); $name = DatabaseManagementService::generateUniqueDatabaseName('something', $server->id);
$host = DatabaseHost::factory()->create(['node_id' => $server->node_id]); $host = DatabaseHost::factory()->create(['node_id' => $server->node_id]);
$this->repository->expects('createDatabase')->with($name)->andThrows(new BadMethodCallException());
$this->repository->expects('dropDatabase')->with($name);
$this->repository->expects('dropUser')->withAnyArgs()->andThrows(new InvalidArgumentException());
$this->expectException(BadMethodCallException::class); $this->expectException(BadMethodCallException::class);
$this->getService()->create($server, [ $dbms = $this->getService();
$dbms->create($server, [
'remote' => '%', 'remote' => '%',
'database' => $name, 'database' => $name,
'database_host_id' => $host->id, 'database_host_id' => $host->id,