62 lines
2.7 KiB
PHP
62 lines
2.7 KiB
PHP
|
<?php
|
||
|
|
|
||
|
|
namespace Pterodactyl\Tests\Integration\Api\Client\Server\Subuser;
|
||
|
|
|
||
|
|
use Mockery;
|
||
|
|
use Pterodactyl\Models\User;
|
||
|
|
use Pterodactyl\Models\Subuser;
|
||
|
|
use Pterodactyl\Repositories\Wings\DaemonServerRepository;
|
||
|
|
use Pterodactyl\Tests\Integration\Api\Client\ClientApiIntegrationTestCase;
|
||
|
|
|
||
|
|
class SubuserAuthorizationTest extends ClientApiIntegrationTestCase
|
||
|
|
{
|
||
|
|
/**
|
||
|
|
* Test that mismatched subusers are not accessible to a server.
|
||
|
|
*
|
||
|
|
* @param string $method
|
||
|
|
* @dataProvider methodDataProvider
|
||
|
|
*/
|
||
|
|
public function testUserCannotAccessResourceBelongingToOtherServers(string $method)
|
||
|
|
{
|
||
|
|
// Generic subuser, the specific resource we're trying to access.
|
||
|
|
/** @var \Pterodactyl\Models\User $internal */
|
||
|
|
$internal = factory(User::class)->create();
|
||
|
|
|
||
|
|
// The API $user is the owner of $server1.
|
||
|
|
[$user, $server1] = $this->generateTestAccount();
|
||
|
|
// Will be a subuser of $server2.
|
||
|
|
$server2 = $this->createServerModel();
|
||
|
|
// And as no access to $server3.
|
||
|
|
$server3 = $this->createServerModel();
|
||
|
|
|
||
|
|
// Set the API $user as a subuser of server 2, but with no permissions
|
||
|
|
// to do anything with the subusers for that server.
|
||
|
|
factory(Subuser::class)->create(['server_id' => $server2->id, 'user_id' => $user->id]);
|
||
|
|
|
||
|
|
factory(Subuser::class)->create(['server_id' => $server1->id, 'user_id' => $internal->id]);
|
||
|
|
factory(Subuser::class)->create(['server_id' => $server2->id, 'user_id' => $internal->id]);
|
||
|
|
factory(Subuser::class)->create(['server_id' => $server3->id, 'user_id' => $internal->id]);
|
||
|
|
|
||
|
|
$this->instance(DaemonServerRepository::class, $mock = Mockery::mock(DaemonServerRepository::class));
|
||
|
|
if ($method === 'DELETE') {
|
||
|
|
$mock->expects('setServer->revokeUserJTI')->with($internal->id)->andReturnUndefined();
|
||
|
|
}
|
||
|
|
|
||
|
|
// This route is acceptable since they're accessing a subuser on their own server.
|
||
|
|
$this->actingAs($user)->json($method, $this->link($server1, "/users/" . $internal->uuid))->assertStatus($method === 'POST' ? 422 : ($method === 'DELETE' ? 204 : 200));
|
||
|
|
|
||
|
|
// This route can be revealed since the subuser belongs to the correct server, but
|
||
|
|
// errors out with a 403 since $user does not have the right permissions for this.
|
||
|
|
$this->actingAs($user)->json($method, $this->link($server2, "/users/" . $internal->uuid))->assertForbidden();
|
||
|
|
$this->actingAs($user)->json($method, $this->link($server3, "/users/" . $internal->uuid))->assertNotFound();
|
||
|
|
}
|
||
|
|
|
||
|
|
/**
|
||
|
|
* @return \string[][]
|
||
|
|
*/
|
||
|
|
public function methodDataProvider(): array
|
||
|
|
{
|
||
|
|
return [["GET"], ["POST"], ["DELETE"]];
|
||
|
|
}
|
||
|
|
}
|