2020-10-08 04:56:44 +00:00
|
|
|
<?php
|
|
|
|
|
|
|
|
namespace Pterodactyl\Tests\Integration\Services\Servers;
|
|
|
|
|
|
|
|
use Exception;
|
2020-10-09 03:38:21 +00:00
|
|
|
use Ramsey\Uuid\Uuid;
|
|
|
|
use Pterodactyl\Models\Egg;
|
|
|
|
use Pterodactyl\Models\User;
|
|
|
|
use Pterodactyl\Models\Nest;
|
2020-10-08 04:56:44 +00:00
|
|
|
use Pterodactyl\Models\Server;
|
|
|
|
use Pterodactyl\Models\ServerVariable;
|
|
|
|
use Illuminate\Validation\ValidationException;
|
|
|
|
use Pterodactyl\Tests\Integration\IntegrationTestCase;
|
2020-10-09 03:38:21 +00:00
|
|
|
use Illuminate\Database\Eloquent\ModelNotFoundException;
|
2020-10-08 04:56:44 +00:00
|
|
|
use Pterodactyl\Services\Servers\StartupModificationService;
|
|
|
|
|
|
|
|
class StartupModificationServiceTest extends IntegrationTestCase
|
|
|
|
{
|
|
|
|
/**
|
|
|
|
* Test that a non-admin request to modify the server startup parameters does
|
|
|
|
* not perform any egg or nest updates. This also attempts to pass through an
|
|
|
|
* egg_id variable which should have no impact if the request is coming from
|
|
|
|
* a non-admin entity.
|
|
|
|
*/
|
|
|
|
public function testNonAdminCanModifyServerVariables()
|
|
|
|
{
|
|
|
|
// Theoretically lines up with the Bungeecord Minecraft egg.
|
|
|
|
$server = $this->createServerModel(['egg_id' => 1]);
|
|
|
|
|
|
|
|
try {
|
|
|
|
$this->app->make(StartupModificationService::class)->handle($server, [
|
|
|
|
'egg_id' => $server->egg_id + 1,
|
|
|
|
'environment' => [
|
|
|
|
'BUNGEE_VERSION' => '$$',
|
|
|
|
'SERVER_JARFILE' => 'server.jar',
|
|
|
|
],
|
|
|
|
]);
|
|
|
|
|
|
|
|
$this->assertTrue(false, 'This assertion should not be called.');
|
|
|
|
} catch (Exception $exception) {
|
|
|
|
$this->assertInstanceOf(ValidationException::class, $exception);
|
|
|
|
|
|
|
|
/** @var \Illuminate\Validation\ValidationException $exception */
|
|
|
|
$errors = $exception->validator->errors()->toArray();
|
|
|
|
|
|
|
|
$this->assertCount(1, $errors);
|
|
|
|
$this->assertArrayHasKey('environment.BUNGEE_VERSION', $errors);
|
|
|
|
$this->assertCount(1, $errors['environment.BUNGEE_VERSION']);
|
|
|
|
$this->assertSame('The Bungeecord Version variable may only contain letters and numbers.', $errors['environment.BUNGEE_VERSION'][0]);
|
|
|
|
}
|
|
|
|
|
|
|
|
ServerVariable::query()->where('variable_id', $server->variables[1]->id)->delete();
|
|
|
|
|
2020-10-09 03:38:21 +00:00
|
|
|
$result = $this->getService()
|
|
|
|
->handle($server, [
|
|
|
|
'egg_id' => $server->egg_id + 1,
|
|
|
|
'startup' => 'random gibberish',
|
|
|
|
'environment' => [
|
|
|
|
'BUNGEE_VERSION' => '1234',
|
|
|
|
'SERVER_JARFILE' => 'test.jar',
|
|
|
|
],
|
|
|
|
]);
|
2020-10-08 04:56:44 +00:00
|
|
|
|
|
|
|
$this->assertInstanceOf(Server::class, $result);
|
|
|
|
$this->assertCount(2, $result->variables);
|
|
|
|
$this->assertSame($server->startup, $result->startup);
|
|
|
|
$this->assertSame('1234', $result->variables[0]->server_value);
|
|
|
|
$this->assertSame('test.jar', $result->variables[1]->server_value);
|
|
|
|
}
|
2020-10-09 03:38:21 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Test that modifying an egg as an admin properly updates the data for the server.
|
|
|
|
*/
|
|
|
|
public function testServerIsProperlyModifiedAsAdminUser()
|
|
|
|
{
|
|
|
|
/** @var \Pterodactyl\Models\Egg $nextEgg */
|
|
|
|
$nextEgg = Nest::query()->findOrFail(2)->eggs()->firstOrFail();
|
|
|
|
|
|
|
|
$server = $this->createServerModel(['egg_id' => 1]);
|
|
|
|
|
|
|
|
$this->assertNotSame($nextEgg->id, $server->egg_id);
|
|
|
|
$this->assertNotSame($nextEgg->nest_id, $server->nest_id);
|
|
|
|
|
|
|
|
$response = $this->getService()
|
|
|
|
->setUserLevel(User::USER_LEVEL_ADMIN)
|
|
|
|
->handle($server, [
|
|
|
|
'egg_id' => $nextEgg->id,
|
|
|
|
'startup' => 'sample startup',
|
|
|
|
'skip_scripts' => true,
|
|
|
|
'docker_image' => 'docker/hodor',
|
|
|
|
]);
|
|
|
|
|
|
|
|
$this->assertInstanceOf(Server::class, $response);
|
|
|
|
$this->assertSame($nextEgg->id, $response->egg_id);
|
|
|
|
$this->assertSame($nextEgg->nest_id, $response->nest_id);
|
|
|
|
$this->assertSame('sample startup', $response->startup);
|
|
|
|
$this->assertSame('docker/hodor', $response->image);
|
|
|
|
$this->assertTrue($response->skip_scripts);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test that hidden variables can be updated by an admin but are not affected by a
|
|
|
|
* regular user who attempts to pass them through.
|
|
|
|
*/
|
|
|
|
public function testEnvironmentVariablesCanBeUpdatedByAdmin()
|
|
|
|
{
|
|
|
|
$server = $this->createServerModel();
|
|
|
|
$server->loadMissing(['egg', 'variables']);
|
|
|
|
|
|
|
|
$clone = $this->cloneEggAndVariables($server->egg);
|
|
|
|
// This makes the BUNGEE_VERSION variable not user editable.
|
|
|
|
$clone->variables()->first()->update([
|
|
|
|
'user_editable' => false,
|
|
|
|
]);
|
|
|
|
|
|
|
|
$server->fill(['egg_id' => $clone->id])->saveOrFail();
|
|
|
|
$server->refresh();
|
|
|
|
|
|
|
|
ServerVariable::query()->updateOrCreate([
|
|
|
|
'server_id' => $server->id,
|
|
|
|
'variable_id' => $server->variables[0]->id,
|
|
|
|
], ['variable_value' => 'EXIST']);
|
|
|
|
|
|
|
|
$response = $this->getService()->handle($server, [
|
|
|
|
'environment' => [
|
|
|
|
'BUNGEE_VERSION' => '1234',
|
|
|
|
'SERVER_JARFILE' => 'test.jar',
|
|
|
|
],
|
|
|
|
]);
|
|
|
|
|
|
|
|
$this->assertCount(2, $response->variables);
|
|
|
|
$this->assertSame('EXIST', $response->variables[0]->server_value);
|
|
|
|
$this->assertSame('test.jar', $response->variables[1]->server_value);
|
|
|
|
|
|
|
|
$response = $this->getService()
|
|
|
|
->setUserLevel(User::USER_LEVEL_ADMIN)
|
|
|
|
->handle($server, [
|
|
|
|
'environment' => [
|
|
|
|
'BUNGEE_VERSION' => '1234',
|
|
|
|
'SERVER_JARFILE' => 'test.jar',
|
|
|
|
],
|
|
|
|
]);
|
|
|
|
|
|
|
|
$this->assertCount(2, $response->variables);
|
|
|
|
$this->assertSame('1234', $response->variables[0]->server_value);
|
|
|
|
$this->assertSame('test.jar', $response->variables[1]->server_value);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Test that passing an invalid egg ID into the function throws an exception
|
|
|
|
* rather than silently failing or skipping.
|
|
|
|
*/
|
|
|
|
public function testInvalidEggIdTriggersException()
|
|
|
|
{
|
|
|
|
$server = $this->createServerModel();
|
|
|
|
|
|
|
|
$this->expectException(ModelNotFoundException::class);
|
|
|
|
|
|
|
|
$this->getService()
|
|
|
|
->setUserLevel(User::USER_LEVEL_ADMIN)
|
|
|
|
->handle($server, ['egg_id' => 123456789]);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @return \Pterodactyl\Services\Servers\StartupModificationService
|
|
|
|
*/
|
|
|
|
private function getService()
|
|
|
|
{
|
|
|
|
return $this->app->make(StartupModificationService::class);
|
|
|
|
}
|
2020-10-08 04:56:44 +00:00
|
|
|
}
|