From f68c46b0a033c07dc71e7be9ffa1db61d9fd5df0 Mon Sep 17 00:00:00 2001
From: Matthew Penner <me@matthewp.io>
Date: Wed, 14 Dec 2022 18:10:12 -0700
Subject: [PATCH] eggs: remove `config_logs` field

---
 app/Models/Egg.php                              | 17 -----------------
 app/Services/Eggs/EggParserService.php          |  1 -
 .../Eggs/Sharing/EggExporterService.php         |  1 -
 .../Api/Application/EggTransformer.php          |  1 -
 4 files changed, 20 deletions(-)

diff --git a/app/Models/Egg.php b/app/Models/Egg.php
index c33e5b194..9ddc2adab 100644
--- a/app/Models/Egg.php
+++ b/app/Models/Egg.php
@@ -20,7 +20,6 @@ use Illuminate\Database\Eloquent\Relations\BelongsTo;
  * @property array|null $file_denylist
  * @property string|null $config_files
  * @property string|null $config_startup
- * @property string|null $config_logs
  * @property string|null $config_stop
  * @property int|null $config_from
  * @property string|null $startup
@@ -36,7 +35,6 @@ use Illuminate\Database\Eloquent\Relations\BelongsTo;
  * @property string $copy_script_container
  * @property string|null $inherit_config_files
  * @property string|null $inherit_config_startup
- * @property string|null $inherit_config_logs
  * @property string|null $inherit_config_stop
  * @property string $inherit_file_denylist
  * @property array|null $inherit_features
@@ -88,7 +86,6 @@ class Egg extends Model
         'file_denylist',
         'config_files',
         'config_startup',
-        'config_logs',
         'config_stop',
         'config_from',
         'startup',
@@ -128,7 +125,6 @@ class Egg extends Model
         'config_from' => 'sometimes|bail|nullable|numeric|exists:eggs,id',
         'config_stop' => 'required_without:config_from|nullable|string|max:191',
         'config_startup' => 'required_without:config_from|nullable|json',
-        'config_logs' => 'required_without:config_from|nullable|json',
         'config_files' => 'required_without:config_from|nullable|json',
         'update_url' => 'sometimes|nullable|string',
         'force_outgoing_ip' => 'sometimes|boolean',
@@ -139,7 +135,6 @@ class Egg extends Model
         'file_denylist' => null,
         'config_stop' => null,
         'config_startup' => null,
-        'config_logs' => null,
         'config_files' => null,
         'update_url' => null,
     ];
@@ -207,18 +202,6 @@ class Egg extends Model
         return $this->configFrom->config_startup;
     }
 
-    /**
-     * Return the log reading configuration for an egg.
-     */
-    public function getInheritConfigLogsAttribute(): ?string
-    {
-        if (!is_null($this->config_logs) || is_null($this->config_from)) {
-            return $this->config_logs;
-        }
-
-        return $this->configFrom->config_logs;
-    }
-
     /**
      * Return the stop command configuration for an egg.
      */
diff --git a/app/Services/Eggs/EggParserService.php b/app/Services/Eggs/EggParserService.php
index c442b8e09..0890c3963 100644
--- a/app/Services/Eggs/EggParserService.php
+++ b/app/Services/Eggs/EggParserService.php
@@ -38,7 +38,6 @@ class EggParserService
             'update_url' => Arr::get($parsed, 'meta.update_url'),
             'config_files' => Arr::get($parsed, 'config.files'),
             'config_startup' => Arr::get($parsed, 'config.startup'),
-            'config_logs' => Arr::get($parsed, 'config.logs'),
             'config_stop' => Arr::get($parsed, 'config.stop'),
             'startup' => Arr::get($parsed, 'startup'),
             'script_install' => Arr::get($parsed, 'scripts.installation.script'),
diff --git a/app/Services/Eggs/Sharing/EggExporterService.php b/app/Services/Eggs/Sharing/EggExporterService.php
index 706297b3d..d52fe7371 100644
--- a/app/Services/Eggs/Sharing/EggExporterService.php
+++ b/app/Services/Eggs/Sharing/EggExporterService.php
@@ -45,7 +45,6 @@ class EggExporterService
             'config' => [
                 'files' => $egg->inherit_config_files,
                 'startup' => $egg->inherit_config_startup,
-                'logs' => $egg->inherit_config_logs,
                 'stop' => $egg->inherit_config_stop,
             ],
             'scripts' => [
diff --git a/app/Transformers/Api/Application/EggTransformer.php b/app/Transformers/Api/Application/EggTransformer.php
index c98a5d16a..ab7328f94 100644
--- a/app/Transformers/Api/Application/EggTransformer.php
+++ b/app/Transformers/Api/Application/EggTransformer.php
@@ -86,7 +86,6 @@ class EggTransformer extends Transformer
                 'files' => json_decode($model->inherit_config_files),
                 'startup' => json_decode($model->inherit_config_startup),
                 'stop' => $model->inherit_config_stop,
-                'logs' => json_decode($model->inherit_config_logs),
             ];
         });
     }