From ba96829d13fcd5818941dca63f97d2182c96afbe Mon Sep 17 00:00:00 2001
From: Lance Pioch <git@lance.sh>
Date: Sun, 13 May 2018 00:41:56 -0400
Subject: [PATCH] Fix cron jobs by removing the extra unusable argument

---
 app/Services/Schedules/ProcessScheduleService.php             | 2 +-
 app/Services/Schedules/ScheduleCreationService.php            | 2 +-
 app/Services/Schedules/ScheduleUpdateService.php              | 2 +-
 tests/Unit/Services/Schedules/ProcessScheduleServiceTest.php  | 2 +-
 tests/Unit/Services/Schedules/ScheduleCreationServiceTest.php | 4 ++--
 tests/Unit/Services/Schedules/ScheduleUpdateServiceTest.php   | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/app/Services/Schedules/ProcessScheduleService.php b/app/Services/Schedules/ProcessScheduleService.php
index ec6ea5f12..b134caa35 100644
--- a/app/Services/Schedules/ProcessScheduleService.php
+++ b/app/Services/Schedules/ProcessScheduleService.php
@@ -63,7 +63,7 @@ class ProcessScheduleService
     {
         $this->repository->loadTasks($schedule);
 
-        $formattedCron = sprintf('%s %s %s * %s *',
+        $formattedCron = sprintf('%s %s %s * %s',
             $schedule->cron_minute,
             $schedule->cron_hour,
             $schedule->cron_day_of_month,
diff --git a/app/Services/Schedules/ScheduleCreationService.php b/app/Services/Schedules/ScheduleCreationService.php
index 9f676e246..c8cbd7fb3 100644
--- a/app/Services/Schedules/ScheduleCreationService.php
+++ b/app/Services/Schedules/ScheduleCreationService.php
@@ -86,7 +86,7 @@ class ScheduleCreationService
      */
     private function getCronTimestamp(array $data)
     {
-        $formattedCron = sprintf('%s %s %s * %s *',
+        $formattedCron = sprintf('%s %s %s * %s',
             array_get($data, 'cron_minute', '*'),
             array_get($data, 'cron_hour', '*'),
             array_get($data, 'cron_day_of_month', '*'),
diff --git a/app/Services/Schedules/ScheduleUpdateService.php b/app/Services/Schedules/ScheduleUpdateService.php
index 96da1b106..1ddbbd242 100644
--- a/app/Services/Schedules/ScheduleUpdateService.php
+++ b/app/Services/Schedules/ScheduleUpdateService.php
@@ -98,7 +98,7 @@ class ScheduleUpdateService
      */
     private function getCronTimestamp(array $data)
     {
-        $formattedCron = sprintf('%s %s %s * %s *',
+        $formattedCron = sprintf('%s %s %s * %s',
             array_get($data, 'cron_minute', '*'),
             array_get($data, 'cron_hour', '*'),
             array_get($data, 'cron_day_of_month', '*'),
diff --git a/tests/Unit/Services/Schedules/ProcessScheduleServiceTest.php b/tests/Unit/Services/Schedules/ProcessScheduleServiceTest.php
index 67db3b626..27e20082a 100644
--- a/tests/Unit/Services/Schedules/ProcessScheduleServiceTest.php
+++ b/tests/Unit/Services/Schedules/ProcessScheduleServiceTest.php
@@ -60,7 +60,7 @@ class ProcessScheduleServiceTest extends TestCase
 
         $this->repository->shouldReceive('loadTasks')->with($model)->once()->andReturn($model);
 
-        $formatted = sprintf('%s %s %s * %s *', $model->cron_minute, $model->cron_hour, $model->cron_day_of_month, $model->cron_day_of_week);
+        $formatted = sprintf('%s %s %s * %s', $model->cron_minute, $model->cron_hour, $model->cron_day_of_month, $model->cron_day_of_week);
         $this->repository->shouldReceive('update')->with($model->id, [
             'is_processing' => true,
             'next_run_at' => CronExpression::factory($formatted)->getNextRunDate(),
diff --git a/tests/Unit/Services/Schedules/ScheduleCreationServiceTest.php b/tests/Unit/Services/Schedules/ScheduleCreationServiceTest.php
index 62d875fcd..117d4a86f 100644
--- a/tests/Unit/Services/Schedules/ScheduleCreationServiceTest.php
+++ b/tests/Unit/Services/Schedules/ScheduleCreationServiceTest.php
@@ -64,7 +64,7 @@ class ScheduleCreationServiceTest extends TestCase
         $this->connection->shouldReceive('beginTransaction')->withNoArgs()->once()->andReturnNull();
         $this->repository->shouldReceive('create')->with([
             'server_id' => $server->id,
-            'next_run_at' => CronExpression::factory('* * * * * *')->getNextRunDate(),
+            'next_run_at' => CronExpression::factory('* * * * *')->getNextRunDate(),
             'test_key' => 'value',
         ])->once()->andReturn($schedule);
         $this->connection->shouldReceive('commit')->withNoArgs()->once()->andReturnNull();
@@ -85,7 +85,7 @@ class ScheduleCreationServiceTest extends TestCase
         $this->connection->shouldReceive('beginTransaction')->withNoArgs()->once()->andReturnNull();
         $this->repository->shouldReceive('create')->with([
             'server_id' => $server->id,
-            'next_run_at' => CronExpression::factory('* * * * * *')->getNextRunDate(),
+            'next_run_at' => CronExpression::factory('* * * * *')->getNextRunDate(),
             'test_key' => 'value',
         ])->once()->andReturn($schedule);
 
diff --git a/tests/Unit/Services/Schedules/ScheduleUpdateServiceTest.php b/tests/Unit/Services/Schedules/ScheduleUpdateServiceTest.php
index 3f26f69b9..4a4dc20db 100644
--- a/tests/Unit/Services/Schedules/ScheduleUpdateServiceTest.php
+++ b/tests/Unit/Services/Schedules/ScheduleUpdateServiceTest.php
@@ -64,7 +64,7 @@ class ScheduleUpdateServiceTest extends TestCase
 
         $this->connection->shouldReceive('beginTransaction')->once()->withNoArgs();
         $this->repository->shouldReceive('update')->once()->with($schedule->id, array_merge($data, [
-            'next_run_at' => CronExpression::factory('1 2 3 * 4 *')->getNextRunDate(),
+            'next_run_at' => CronExpression::factory('1 2 3 * 4')->getNextRunDate(),
         ]))->andReturn($schedule);
 
         $this->taskRepository->shouldReceive('deleteWhere')->once()->with([['schedule_id', '=', $schedule->id]]);