From 8df5d5beaf470bc02e51681b64d9f546f3ec1ab7 Mon Sep 17 00:00:00 2001 From: Dane Everitt Date: Tue, 19 Sep 2017 22:15:52 -0500 Subject: [PATCH] Remove unnecessary test and cleanup rebuild command --- app/Console/Commands/Server/RebuildServerCommand.php | 3 +-- tests/Unit/Services/Servers/EnvironmentServiceTest.php | 10 ---------- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/app/Console/Commands/Server/RebuildServerCommand.php b/app/Console/Commands/Server/RebuildServerCommand.php index b76c286be..c61ae98d9 100644 --- a/app/Console/Commands/Server/RebuildServerCommand.php +++ b/app/Console/Commands/Server/RebuildServerCommand.php @@ -86,9 +86,8 @@ class RebuildServerCommand extends Command { $servers = $this->getServersToProcess(); $bar = $this->output->createProgressBar(count($servers)); - $results = []; - $servers->each(function ($server) use ($bar, &$results) { + $servers->each(function ($server) use ($bar) { $bar->clear(); $json = [ 'build' => [ diff --git a/tests/Unit/Services/Servers/EnvironmentServiceTest.php b/tests/Unit/Services/Servers/EnvironmentServiceTest.php index 7dc5c2719..583ce8aed 100644 --- a/tests/Unit/Services/Servers/EnvironmentServiceTest.php +++ b/tests/Unit/Services/Servers/EnvironmentServiceTest.php @@ -142,14 +142,4 @@ class EnvironmentServiceTest extends TestCase $this->assertTrue(is_array($response), 'Assert that response is an array.'); } - - /** - * Test that an exception is thrown when no model or valid ID is provided. - * - * @expectedException \InvalidArgumentException - */ - public function testProcessShouldThrowExceptionIfInvalidServerIsProvided() - { - $this->service->process('abcd'); - } }