From 0216e3fd5b084dc8d2dd2171e0599929ce5aaa8c Mon Sep 17 00:00:00 2001 From: DaneEveritt Date: Sun, 3 Jul 2022 14:29:01 -0400 Subject: [PATCH] Don't log activity if the email wasn't actually changed --- app/Http/Controllers/Api/Client/AccountController.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/Http/Controllers/Api/Client/AccountController.php b/app/Http/Controllers/Api/Client/AccountController.php index 9551bf690..db7a1971d 100644 --- a/app/Http/Controllers/Api/Client/AccountController.php +++ b/app/Http/Controllers/Api/Client/AccountController.php @@ -50,9 +50,11 @@ class AccountController extends ClientApiController $original = $request->user()->email; $this->updateService->handle($request->user(), $request->validated()); - Activity::event('user:account.email-changed') - ->property(['old' => $original, 'new' => $request->input('email')]) - ->log(); + if ($original !== $request->input('email')) { + Activity::event('user:account.email-changed') + ->property(['old' => $original, 'new' => $request->input('email')]) + ->log(); + } return new JsonResponse([], Response::HTTP_NO_CONTENT); }