From 0135f7ee8e054c0ca64831d5d0717ee82655018a Mon Sep 17 00:00:00 2001
From: Dane Everitt <dane@daneeveritt.com>
Date: Fri, 2 Mar 2018 21:26:42 -0600
Subject: [PATCH] Add test for new command

---
 .../Server/BulkPowerActionCommand.php         |   4 +-
 .../Server/BulkPowerActionCommandTest.php     | 164 ++++++++++++++++++
 2 files changed, 167 insertions(+), 1 deletion(-)
 create mode 100644 tests/Unit/Commands/Server/BulkPowerActionCommandTest.php

diff --git a/app/Console/Commands/Server/BulkPowerActionCommand.php b/app/Console/Commands/Server/BulkPowerActionCommand.php
index dbe36718d..ced90db81 100644
--- a/app/Console/Commands/Server/BulkPowerActionCommand.php
+++ b/app/Console/Commands/Server/BulkPowerActionCommand.php
@@ -4,6 +4,7 @@ namespace Pterodactyl\Console\Commands\Server;
 
 use Illuminate\Console\Command;
 use GuzzleHttp\Exception\RequestException;
+use Illuminate\Validation\ValidationException;
 use Illuminate\Validation\Factory as ValidatorFactory;
 use Pterodactyl\Contracts\Repository\ServerRepositoryInterface;
 use Pterodactyl\Contracts\Repository\Daemon\PowerRepositoryInterface;
@@ -60,6 +61,7 @@ class BulkPowerActionCommand extends Command
     /**
      * Handle the bulk power request.
      *
+     * @throws \Illuminate\Validation\ValidationException
      * @throws \Pterodactyl\Exceptions\Repository\Daemon\InvalidPowerSignalException
      */
     public function handle()
@@ -85,7 +87,7 @@ class BulkPowerActionCommand extends Command
                 $this->output->error($message);
             }
 
-            return;
+            throw new ValidationException($validator);
         }
 
         $count = $this->repository->getServersForPowerActionCount($servers, $nodes);
diff --git a/tests/Unit/Commands/Server/BulkPowerActionCommandTest.php b/tests/Unit/Commands/Server/BulkPowerActionCommandTest.php
new file mode 100644
index 000000000..684baf931
--- /dev/null
+++ b/tests/Unit/Commands/Server/BulkPowerActionCommandTest.php
@@ -0,0 +1,164 @@
+<?php
+
+namespace Tests\Unit\Commands\Server;
+
+use Mockery as m;
+use Pterodactyl\Models\Server;
+use Illuminate\Validation\Factory;
+use Tests\Unit\Commands\CommandTestCase;
+use Pterodactyl\Console\Commands\Server\BulkPowerActionCommand;
+use Pterodactyl\Contracts\Repository\ServerRepositoryInterface;
+use Pterodactyl\Contracts\Repository\Daemon\PowerRepositoryInterface;
+
+class BulkPowerActionCommandTest extends CommandTestCase
+{
+    /**
+     * @var \Pterodactyl\Contracts\Repository\Daemon\PowerRepositoryInterface|\Mockery\Mock
+     */
+    private $powerRepository;
+
+    /**
+     * @var \Pterodactyl\Contracts\Repository\ServerRepositoryInterface|\Mockery\Mock
+     */
+    private $repository;
+
+    /**
+     * Setup test.
+     */
+    public function setUp()
+    {
+        parent::setUp();
+
+        $this->powerRepository = m::mock(PowerRepositoryInterface::class);
+        $this->repository = m::mock(ServerRepositoryInterface::class);
+    }
+
+    /**
+     * Test that an action can be sent to all servers.
+     */
+    public function testSendAction()
+    {
+        $servers = factory(Server::class)->times(2)->make();
+
+        $this->repository->shouldReceive('getServersForPowerActionCount')
+            ->once()
+            ->with([], [])
+            ->andReturn(2);
+
+        $this->repository->shouldReceive('getServersForPowerAction')
+            ->once()
+            ->with([], [])
+            ->andReturn($servers);
+
+        for ($i = 0; $i < count($servers); $i++) {
+            $this->powerRepository->shouldReceive('setServer->sendSignal')
+                ->once()
+                ->with('kill')
+                ->andReturnNull();
+        }
+
+        $display = $this->runCommand($this->getCommand(), ['action' => 'kill'], ['yes']);
+
+        $this->assertNotEmpty($display);
+        $this->assertContains('2/2', $display);
+        $this->assertContains(trans('command/messages.server.power.confirm', ['action' => 'kill', 'count' => 2]), $display);
+    }
+
+    /**
+     * Test filtering servers and nodes.
+     */
+    public function testSendWithFilters()
+    {
+        $server = factory(Server::class)->make();
+
+        $this->repository->shouldReceive('getServersForPowerActionCount')
+            ->once()
+            ->with([1, 2], [3, 4])
+            ->andReturn(1);
+
+        $this->repository->shouldReceive('getServersForPowerAction')
+            ->once()
+            ->with([1, 2], [3, 4])
+            ->andReturn([$server]);
+
+        $this->powerRepository->shouldReceive('setServer->sendSignal')
+            ->once()
+            ->with('kill')
+            ->andReturnNull();
+
+        $display = $this->runCommand($this->getCommand(), [
+            'action' => 'kill',
+            '--servers' => '1,2',
+            '--nodes' => '3,4',
+        ], ['yes']);
+
+        $this->assertNotEmpty($display);
+        $this->assertContains('1/1', $display);
+        $this->assertContains(trans('command/messages.server.power.confirm', ['action' => 'kill', 'count' => 1]), $display);
+    }
+
+    /**
+     * Test that sending empty options returns the expected results.
+     */
+    public function testSendWithEmptyOptions()
+    {
+        $server = factory(Server::class)->make();
+
+        $this->repository->shouldReceive('getServersForPowerActionCount')
+            ->once()
+            ->with([], [])
+            ->andReturn(1);
+
+        $this->repository->shouldReceive('getServersForPowerAction')->once()->with([], [])->andReturn([$server]);
+        $this->powerRepository->shouldReceive('setServer->sendSignal')->once()->with('kill')->andReturnNull();
+
+        $display = $this->runCommand($this->getCommand(), [
+            'action' => 'kill',
+            '--servers' => '',
+            '--nodes' => '',
+        ], ['yes']);
+
+        $this->assertNotEmpty($display);
+        $this->assertContains('1/1', $display);
+        $this->assertContains(trans('command/messages.server.power.confirm', ['action' => 'kill', 'count' => 1]), $display);
+    }
+
+    /**
+     * Test that validation occurrs correctly.
+     *
+     * @param array $data
+     *
+     * @dataProvider validationFailureDataProvider
+     * @expectedException \Illuminate\Validation\ValidationException
+     */
+    public function testValidationErrors(array $data)
+    {
+        $this->runCommand($this->getCommand(), $data);
+    }
+
+    /**
+     * Provide invalid data for the command.
+     *
+     * @return array
+     */
+    public function validationFailureDataProvider(): array
+    {
+        return  [
+            [['action' => 'hodor']],
+            [['action' => 'hodor', '--servers' => 'hodor']],
+            [['action' => 'kill', '--servers' => 'hodor']],
+            [['action' => 'kill', '--servers' => '1,2,3', '--nodes' => 'hodor']],
+            [['action' => 'kill', '--servers' => '1,2,3', '--nodes' => '1,2,test']],
+        ];
+    }
+
+    /**
+     * Return an instance of the command with mocked dependencies.
+     *
+     * @return \Pterodactyl\Console\Commands\Server\BulkPowerActionCommand
+     */
+    private function getCommand(): BulkPowerActionCommand
+    {
+        return new BulkPowerActionCommand($this->powerRepository, $this->repository, $this->app->make(Factory::class));
+    }
+}