From eec783bd77d98065a8dbde5f34601b2294e57885 Mon Sep 17 00:00:00 2001
From: Brendan Golden <git_laptop@brendan.ie>
Date: Mon, 1 Jan 2024 09:31:32 +0000
Subject: [PATCH] feat: Moved the JS out of the password recovery page into its
 own file

Related to #9
---
 src/recovery/password.html | 52 +++-----------------------------------
 src/recovery/password.js   | 50 ++++++++++++++++++++++++++++++++++++
 2 files changed, 53 insertions(+), 49 deletions(-)
 create mode 100644 src/recovery/password.js

diff --git a/src/recovery/password.html b/src/recovery/password.html
index 89ea4c3..e00e3d2 100644
--- a/src/recovery/password.html
+++ b/src/recovery/password.html
@@ -17,7 +17,7 @@
         <p>
           Request a password reset sent to your linked email. <br> Enter either email address or skynet username. </br>
         </p>
-        <form id="recovery">
+        <form id="form">
           <table id="table">
             <tr>
               <td><label for="username">Username</label></td>
@@ -31,58 +31,12 @@
               <td><input id="email" name="email" type="text"/> <br/></td>
             </tr>
             <tr>
-              <td colspan="2"><input type="submit" value="submit"/></td>
+              <td colspan="2"><input id="button" type="submit" value="submit"/></td>
             </tr>
           </table>
         </form>
         <p id="formStatus"></p>
-        <script>
-          const formEl = document.getElementById('recovery');
-          formEl.addEventListener('submit', formHandler);
-
-          async function formHandler(listener) {
-            listener.preventDefault();
-
-            // reset teh form status
-            document.getElementById('formStatus').innerHTML = "<span style='background-color: green; color: white'>Please wait.</span>";
-
-            const formData = new FormData(formEl);
-            const username = formData.get('username').trim();
-            const email = formData.get('email').trim();
-
-            if (username.length === 0 && email.length === 0) {
-              document.getElementById('formStatus').innerHTML = "<span style='background-color: red; color: white'>Please enter username or email</span>";
-              return;
-            }
-
-            let to_send = {
-              email: email
-            };
-
-            // assuming username is not empty it is the preferred method
-            if (username.length > 0) {
-              to_send = {user: username};
-            }
-
-            let url = "https://api.account.skynet.ie/ldap/recover/password";
-
-            try {
-              let req = await fetch(url, {
-                method: 'POST',
-                body: JSON.stringify(to_send),
-                mode: "cors"
-              });
-
-              if (req.status === 200) {
-                document.getElementById('formStatus').innerHTML = "<span style='background-color: green; color: white'>Success Please check emails</span>";
-              } else {
-                document.getElementById('formStatus').innerHTML = "<span style='background-color: red; color: white'>Failure: Failed to communicate to server</span>";
-              }
-            } catch (e) {
-              document.getElementById('formStatus').innerHTML = `<span style='background-color: red; color: white'>Error: ${e}</span>`;
-            }
-          }
-        </script>
+        <script src="password.js"></script>
       </main>
       <footer class="page-footer">
         UL Computer Society 2023-<span id="year">2023</span>
diff --git a/src/recovery/password.js b/src/recovery/password.js
new file mode 100644
index 0000000..24bf53e
--- /dev/null
+++ b/src/recovery/password.js
@@ -0,0 +1,50 @@
+const form = document.getElementById("form");
+form.addEventListener('submit',  formHandler);
+
+const form_status = document.getElementById("formStatus");
+
+const button = document.getElementById("button");
+button.addEventListener('submit', formHandler);
+
+async function formHandler(listener) {
+    listener.preventDefault();
+
+    // reset teh form status
+    form_status.innerHTML = "<span style='background-color: green; color: white'>Please wait.</span>";
+
+    const formData = new FormData(form);
+    const username = formData.get('username').trim();
+    const email = formData.get('email').trim();
+
+    if (username.length === 0 && email.length === 0) {
+        form_status.innerHTML = "<span style='background-color: red; color: white'>Please enter username or email</span>";
+        return;
+    }
+
+    let to_send = {
+        email: email
+    };
+
+    // assuming username is not empty it is the preferred method
+    if (username.length > 0) {
+        to_send = {user: username};
+    }
+
+    let url = "https://api.account.skynet.ie/ldap/recover/password";
+
+    try {
+        let req = await fetch(url, {
+            method: 'POST',
+            body: JSON.stringify(to_send),
+            mode: "cors"
+        });
+
+        if (req.status === 200) {
+            form_status.innerHTML = "<span style='background-color: green; color: white'>Success Please check emails</span>";
+        } else {
+            form_status.innerHTML = "<span style='background-color: red; color: white'>Failure: Failed to communicate to server</span>";
+        }
+    } catch (e) {
+        form_status.innerHTML = `<span style='background-color: red; color: white'>Error: ${e}</span>`;
+    }
+}
\ No newline at end of file